Repository navigation
Conversation
ASIDISG
added a commit
to ASIDISG/Revora-Contracts
that referenced
this pull request
Sep 28, 2026
Fixes the CI / Format check (cargo fmt) gate on PR RevoraOrg#1282 and re-stacks the branch onto the formatted RevoraOrg#1058 tip. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
ASIDISG
force-pushed
the
test/1059-accept-issuer-transfer
branch
from
September 28, 2026 14:21
850a051 to
4d40ee8
Compare
ASIDISG
added a commit
to ASIDISG/Revora-Contracts
that referenced
this pull request
Sep 29, 2026
Fixes the CI / Format check (cargo fmt) gate on PR RevoraOrg#1282 and re-stacks the branch onto the formatted RevoraOrg#1058 tip. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com> (cherry picked from commit 4d40ee8)
ASIDISG
force-pushed
the
test/1059-accept-issuer-transfer
branch
3 times, most recently
from
September 29, 2026 16:52
ad33a77 to
f704141
Compare
Brings master in line with the repository's own Format check (cargo fmt --all -- --check), which fails on master today (40 hunks). Formatting only; no code or test changes.
New module src/test_accept_issuer_transfer.rs and its mod declaration. Closes RevoraOrg#1059.
ASIDISG
force-pushed
the
test/1059-accept-issuer-transfer
branch
from
October 16, 2026 01:41
f704141 to
c3509fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
src/test_accept_issuer_transfer.rs, an adversarial suite foraccept_issuer_transfer.NoTransferPending(the pending survives the uninvolved attempt); a duplicate target offering isLimitReachedwith the pending preserved;ContractFrozen;ContractPaused(and works after unpause)IssuerTransferExpiredwith the pending preserved; a custom window expires past itself even while the default window would still be openAuthorization note:
accept_issuer_transfercallsnew_issuer.require_auth()first; a host auth failure is a non-unwinding panic thattry_*cannot capture (the same limitation documented intest_auth.rs), so wrong-identity rejection is covered through the typed paths above.Closes #1059
Independence and verification
src/test_accept_issuer_transfer.rsplus its two-linemoddeclaration insrc/lib.rs, on top of the sharedstyle: cargo fmt --allcommit (test: make the lib test target build and run to completion #1272 carries the identical commit, so the four test PRs and test: make the lib test target build and run to completion #1272 merge in any order without conflicts; I checked all orders by merging them together).cargo fmt --all -- --checkis clean on this branch.master's lib test target does not currently compile; test: make the lib test target build and run to completion #1272 fixes that. Verification was run on this branch merged with test: make the lib test target build and run to completion #1272:and with all four test branches merged together: 53 passed, 0 failed.
Not claimed
The earlier version of this PR stacked on the other three and quoted "307 passed" from a different base. Those numbers are gone; the figures above are what this branch produces.