Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds focused adversarial test coverage for the public
get_revenue_by_periodcontract insrc/lib.rs. The new test module exercises valid calls, boundary values, unauthorized callers, and verifies that state remains unchanged after rejected operations.Related Issue
Changes
🧪 Revenue-by-Period Test Coverage
src/test_revenue_by_period.rsget_revenue_by_period(env, issuer, namespace, token, period_id).Env,Addressissuer,Symbolnamespace,Addresstoken, and representativeperiod_idvalues.period_id = 0,u64::MAX, and periods with no recorded revenue.Verification Results
src/test_revenue_by_period.rsget_revenue_by_periodsignature or behaviorperiod_idvalues and rejected unauthorized callsCloses #1086