Skip to content

feat: add onHit to BaseSpace #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nyuwaea merged 3 commits into from
Aug 11, 2026
Merged

feat: add onHit to BaseSpace #118

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ad3d30
feat: add onHit to BaseSpace
nyarw Aug 11, 2026
c3a471b
remove exittree as its unnecessary
nyarw Aug 11, 2026
b2e695c
add the function back without the base method
nyarw Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions scripts/spaces/BaseSpace.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,22 @@ public override void _Ready()
WorldEnvironment = GetNode<WorldEnvironment>("WorldEnvironment");
}

private void onHitResultChanged(int noteIndex, HitResult hitResult)
{
if (hitResult == HitResult.Hit)
{
OnHit(Game.Instance.Runner.Attempt.Combo);
}
}

public override void _ExitTree()
{
if (Game.Instance?.Runner != null)
{
Game.Instance.Runner.HitResultChanged -= onHitResultChanged;
}
}

public override void _Process(double delta)
{
base._Process(delta);
Expand All @@ -38,6 +54,10 @@ public override void _Process(double delta)
}
}

public virtual void OnHit(uint combo)
{
}

public virtual void Load()
{
var skin = SkinManager.Instance.Skin;
Expand All @@ -54,5 +74,11 @@ public virtual void UpdateState(bool playing)
{
Playing = playing;
Camera.Current = !Playing;

if (Playing && Game.Instance?.Runner != null)
{
Game.Instance.Runner.HitResultChanged -= onHitResultChanged;
Game.Instance.Runner.HitResultChanged += onHitResultChanged;
}
}
}
Loading