Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Projects lose their settings and figure identity when the process restarts. This change adds a shared JSON v1 recipe to the web app and CLI, and preserves every valid imported configuration and individual figure value through generation and export. A CLI project with a fixed 30 mm height and automatic width/depth now generates the same mesh in a fresh web session and reopens unchanged in another CLI process.
This PR is stacked on #12 (
fix/hidden-values-fallback-freshness), the direct OPE-8 prerequisite. Integrate #12 before retargeting this PR tomain. #11 and #13 remain separate work required before broader delivery; their dependency-security and small-wall fixes are not included here.inlayer-project, version 1 contains every Config field, persistent figure ids, full SHA-256 source identities, and individual rotations/offsets/grip positions. STL bytes remain external. Invalid recipes and missing/changed/extra sources fail before generation.null; fractional values, inactive settings, and global versus individual offsets survive language, selection, and hidden-control changes. Only deliberate edits replace corresponding values. Both UI languages explain control projections.--save-projectexports a recipe;--projectreopens recipe-relative paths or hash-matched-ireplacements. Config flags cannot override a recipe. JSON destinations cannot overwrite source/output STLs.Validation at
2cc3a3da6f1e2775bdf5f53f28c66f828eb3897b: Python 3.13.5 full pytest 673 passed in 109.78 s. The eight-case CLI→fresh Web→new CLI matrix covers partial box/cylinder dimensions, fractional values, values outside ordinary controls and disabled recesses, with reversed same-named distinct sources. It checks exact pipeline inputs, ids/hashes/settings, finished mesh dimensions, independent cavity/wall measurements, symmetric solid differences and wall findings. EN/DE and existing upload/cache/selection isolation remain covered. Independent semantic review completed with no open findings; discovered state bugs have regression tests. Pyrefly 1.4.1 has the same 31 existing diagnostics as the previous head, with no additions.git diff --checkis clean.CI run 43202461078 passed at the exact head: Python 3.13 tests, Docker test stage, runtime build and import/health smoke. The former 655-test result and run 43178464205 apply only to the superseded head
bd0a7a6. Local Docker/Podman is unavailable. No merge, release or production action is included.