Repository navigation
fix: place finger recesses on the sunk part of the figure (OPE-9) - #15
Merged
Merged
Conversation
_recess_pair measured the silhouette over every Z layer, so a wide head standing out above the box pulled the recesses off a narrow sunk stem: a T figure left three separate pockets with a green wall check. The silhouette and the grip length now come from the vertices below the top face, after the figure's own Z offset. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
_recess_pairtook the figure's silhouette over all Z layers. With a T/mushroom figure (4×20×25 mm stem, 40×20×5 mm head, depth 0.7, pitch 0.5, default radius 8), only the stem is sunk, but the recesses followed the 40 mm head. The finished STL had three separate pockets: the cavity plus two finger holes that do not touch it. The wall check was still green.Change
_recess_pair(..., top_z)now measures silhouette and grip length only on vertices below the box's top face.build_inlaypassestop_z = -offset_z, so a figure raised by its own Z offset is measured on what actually stays sunk.no_cavityfor that case.Measured on the finished STL (
geometry_probe.cavities)finger_recess_z_offsetTests
test_recesses_join_the_cavity_under_an_overhanging_head[0.0, 4.0]: T figure, default radius, one pocket.test_recesses_follow_the_sunk_part_after_a_z_offset: cone raised by an individual Z offset until only its narrow part is sunk.577 passed(Python 3.13). Docker was not available locally, so the container check runs only in CI.README and AGENTS.md updated. No release.
🤖 Generated with Claude Code