refactor(ui): explicit-dep highlight effect + Tauri→Wails prose - #402
Open
rigel-mintaka wants to merge 1 commit into
Open
refactor(ui): explicit-dep highlight effect + Tauri→Wails prose#402rigel-mintaka wants to merge 1 commit into
rigel-mintaka wants to merge 1 commit into
Conversation
S1 (RIG-2199): convert the MarkdownText highlight-debounce effect to createEffect(on([code, lang, () => props.inline], apply)), mirroring the MessageStream on(deps, apply) shape. Tracks all three implicit reactive reads explicitly so the v1-safe prep is 1:1 with Solid 2's split effects; inline is included defensively (structural per instance) so the guard can never read a stale value. Debounce/onCleanup semantics unchanged. S3 (RIG-2201): replace the stale "Tauri" comments with Wails at the six real prose sites (App.tsx, stub-data.ts, live/client.ts, live/connection.ts, markdown/highlighter.ts); the runtime binding is @wailsio/runtime. Fixture strings and the deliberate daemon-transport.test.ts note left unchanged. Refs RIG-2199, RIG-2201 Co-authored-by: Matt Wilkinson <matt@sealedsecurity.com>
|
Compass engineering docs preview: https://compass-ui-rig-2199-effect-d.compass-eng-docs.pages.dev Deployed from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S1 (RIG-2199): convert the MarkdownText highlight-debounce effect to
createEffect(on([code, lang, () => props.inline], apply)), mirroring the
MessageStream on(deps, apply) shape. Tracks all three implicit reactive
reads explicitly so the v1-safe prep is 1:1 with Solid 2's split effects;
inline is included defensively (structural per instance) so the guard can
never read a stale value. Debounce/onCleanup semantics unchanged.
S3 (RIG-2201): replace the stale "Tauri" comments with Wails at the six
real prose sites (App.tsx, stub-data.ts, live/client.ts, live/connection.ts,
markdown/highlighter.ts); the runtime binding is @wailsio/runtime. Fixture
strings and the deliberate daemon-transport.test.ts note left unchanged.
Refs RIG-2199, RIG-2201
Co-authored-by: Matt Wilkinson matt@sealedsecurity.com