Repository navigation
v1.3.2: stop reading session-id environment variables - #13
Merged
Merged
Conversation
The directory still holds the plugin under MCP_FORWARDS_CREDENTIAL_ENV. 1.3.1 only moved URLs away from the CLAUDE_*_SESSION_ID reads; the reads themselves are what the rule treats as a credential. They were a fallback: the PostToolUse hook payload already carries session_id, and Claude Code writes a Claude-Session trailer. So drop the reads instead of rearranging them. - core/receipt.py: no CLAUDE_CODE_SESSION_ID / CLAUDE_SESSION_ID reads; session id from the hook payload or the Claude-Session trailer only. - tests: env session ids are ignored, trailer still recorded, and no shipped file (core/, hooks/, action.yml) names a SESSION_ID variable. - README disclosure, badge.py note, CHANGELOG, version 1.3.2. - 125 tests pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BphvC1wMrXK1TseCjhappZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The directory still holds the plugin under MCP_FORWARDS_CREDENTIAL_ENV.
1.3.1 only moved URLs away from the CLAUDE_*_SESSION_ID reads; the reads
themselves are what the rule treats as a credential. They were a fallback:
the PostToolUse hook payload already carries session_id, and Claude Code
writes a Claude-Session trailer. So drop the reads instead of rearranging
them.
session id from the hook payload or the Claude-Session trailer only.
shipped file (core/, hooks/, action.yml) names a SESSION_ID variable.
Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01BphvC1wMrXK1TseCjhappZ