Skip to content

Add Chinese page navigation keys to Deep Nav - #537

Open
mdroidian wants to merge 2 commits into
mainfrom
codex/deepnav-chinese-page-navigation
Open

Add Chinese page navigation keys to Deep Nav#537
mdroidian wants to merge 2 commits into
mainfrom
codex/deepnav-chinese-page-navigation

Conversation

@mdroidian

@mdroidian mdroidian commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • generate Deep Nav shortcuts for Chinese page titles using abbreviations and full pinyin
  • navigate page references and page aliases directly while preserving block breadcrumb navigation
  • add focused regression coverage for Latin, Chinese, and mixed alias key generation

Addresses #510

Verification

  • npm run test:deepnav (4 passing)
  • npm run build:roam
  • real-Roam Playwright verification for abbreviation (zw), full-pinyin alternative (zh), Chinese alias (cs), and block breadcrumb (ct) navigation
  • inspected screenshots and complete 19.64-second WebM; zero page, console, or request errors

Baseline limitations

  • repository-wide npx tsc --noEmit has existing errors outside the changed files
  • fresh npm ci hits the existing macOS lockfile platform issue for @esbuild/android-arm

Open in Devin Review

@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 23739369-90aa-4f50-96eb-83473a2ab2e9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d812266f78

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/features/deepnav.tsx

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@mdroidian

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: 147cc8f177

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant