Repository navigation
Release v1.3.1: read git.allowTrunkPush through a relative hooks path - #19
Merged
Merged
Conversation
…ssue row on main The pre-push hook passed a relative module path to Import-Module, which read it as a module name, so every push to main was refused. On main with the setting on, the pre-flight issue-contract row is now SKIP. Refs #18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #18
What changes
Import-Module.core.hooksPathis relative, so the path was relative too, andImport-Moduleread it as a module name. The setting then counted as off, and every push tomainwas refused.git pushthrough a relativecore.hooksPath, with the setting on and off. It fails on the v1.3.0 hook.mainormasterwithgit.allowTrunkPushon, the pre-flight issue-contract row is SKIP instead of FAIL. It stays FAIL on any other branch without a story key.layout.mdnames the SKIP row. The CHANGELOG has a v1.3.1 entry, and every package is at 1.3.1.Checks
The pre-flight passes: gates, tests and the secret scan.