Repository navigation
Release v1.4.1: run apm install in a local worktree on a network share - #26
Merged
Merged
Conversation
On a network share, APM 0.31.0 reported a good install but left the changed skill folders empty, and its lock listed those folders, so a second run skipped them. The same install on a local disk was correct. Install-AiSdlc.ps1 and Update-AiSdlc.ps1 now call Invoke-ApmInstall. On a share it runs apm in a local git worktree of HEAD, with the working copies of the files apm reads or merges into. Then it copies each file of the new lock that differs from the share, and removes each file that only the old lock listed. The share check is the one the pre-push hook uses, and AISDLC_APM_LOCAL_INSTALL forces it on or off. Proven on a consumer on a share: a move of its private packs from v1.0.4 to v1.0.3 and back gave the exact files of each tag, in 20 seconds instead of about 3 minutes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #20
#20 made the pre-push gates work on a network share. This takes the same idea to
apm install, the other step that breaks there.What changes
Invoke-ApmInstallinAiSdlcSetup.ps1, used byInstall-AiSdlc.ps1andUpdate-AiSdlc.ps1instead of a bareapm install.apmruns in the repository.apmin a temporary local git worktree ofHEAD, with the working copies ofapm.yml,apm.lock.yaml,aisdlc.json,.mcp.jsonand.claude/settings.json. Then it copies each file of the new lock that differs from the share, and removes each file that only the old lock listed.//host/share, also for a mapped drive).AISDLC_APM_LOCAL_INSTALL=1forces the worktree,=0turns it off.Test-AiSdlcNetworkPathandGet-ApmDeployedFilesupport it.ai-sdlc-hooks/SKILL.md,CHANGELOG.md, everyapm.ymlat 1.4.1, the sync manifest and the self-install.Why
On a network share, APM 0.31.0 reported "Installed 5 APM dependencies" but left the changed skill folders empty. Its lock then listed those folders instead of their files, so a second run skipped them. The same install on a local disk was correct and took 11 seconds instead of about 3 minutes.
Testing
AiSdlcSetup,Update-AiSdlcandInstall-AiSdlc. The new ones cover the worktree path, a failingapm, the lock reader, and a share whose working copy differs fromHEAD.mainagain.git statusrefused the worktree as dubious ownership (its git folder is on the share), and a comparison withHEADinstead of the share missed a share that was ahead ofHEAD. A failedgit statusnow fails the install instead of passing in silence.Notes
apm install. The theme is the same, so this PR refers to it instead of opening a new issue.