Repository navigation
Release v1.4.2: trust the gate checkout on a share, fail a blind secret scan, audit in the worktree - #27
Merged
Conversation
…et scan, audit in the worktree
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #20
Three fixes for a consumer on a network share, found while taking v1.4.1 on one.
What changed
GIT_CONFIG_COUNT/GIT_CONFIG_KEY_0/GIT_CONFIG_VALUE_0(safe.directory), only for the gate processes. The git config of the machine is not changed.cygpath -mgives theC:/...form that git on Windows compares.Test-GitleaksBaseline.ps1checksgit rev-parse HEADbefore it scans. When git cannot read the folder, it exits 2 locally and 1 in GitHub Actions, never 0.Update-AiSdlc.ps1ranapm audit --cion the share, whereapm_modulesdoes not exist, so the audit failed after a correct install and nothing was staged.Invoke-ApmInstalltakes-AuditCode [ref]and runs the audit in the same folder as the install: the worktree on a share, the repository itself otherwise. A failed audit leaves the share as it was.How it was tested
safe.directoryto the checkout; the audit runs in the worktree, only after a good install, and a failed audit leaves the share unchanged.AiSdlcSetup26/26,PrePushHook34/34,Test-GitleaksBaselineall pass.Invoke-ApmInstall -AuditCoderan a frozen install and the audit in the worktree: all 10 audit checks passed and the share was left unchanged.Release steps after the merge: tag
v1.4.2withRelease v1.4.2 for #20, publish the release. #20 is already closed with itsrefinedlabel.