Skip to content

Increase --batch_size for all jobs in main.yml - #309

Closed
sea-bass wants to merge 1 commit into
mainfrom
increase-linux64-batch-size
Closed

sea-bass wants to merge 1 commit into
mainfrom
increase-linux64-batch-size

Conversation

@sea-bass

@sea-bass sea-bass commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

I measured these locally to fix the issue.

  ┌───────────────┬─────────┬──────────────────────┬──────────────────────┐
  │   Platform    │ Recipes │ Old batch size → KiB │ New batch size → KiB │
  ├───────────────┼─────────┼──────────────────────┼──────────────────────┤
  │ linux-64      │ 2269    │ 5 → 683 ❌           │ 10 → 402             │
  ├───────────────┼─────────┼──────────────────────┼──────────────────────┤
  │ linux-aarch64 │ 2269    │ 5 → 689 ❌           │ 10 → 406             │
  ├───────────────┼─────────┼──────────────────────┼──────────────────────┤
  │ osx-64        │ 2035    │ 5 → 595 ❌           │ 10 → 355             │
  ├───────────────┼─────────┼──────────────────────┼──────────────────────┤
  │ osx-arm64     │ 2035    │ 5 → 593 ❌           │ 10 → 355             │
  ├───────────────┼─────────┼──────────────────────┼──────────────────────┤
  │ win-64        │ 1691    │ 20 → 536 ❌          │ 25 → 439             │
  └───────────────┴─────────┴──────────────────────┴──────────────────────┘

But the root cause is that the testpr.yml that theoretically could have caught this had a hard-coded --batch_size 25 for all OSes, so it did not find this before merging the last PR.

@sea-bass sea-bass changed the title Increase --batch_size for all jobs in test.yml Increase --batch_size for all jobs in main.yml Oct 8, 2026
@sea-bass
sea-bass force-pushed the increase-linux64-batch-size branch from 0bf776f to 261532e Compare October 8, 2026 02:37
@Tobias-Fischer

Copy link
Copy Markdown
Contributor

Sorry I just did this on main ;)

@sea-bass

sea-bass commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor Author

thanks @Tobias-Fischer -- note that your numbers (all 25s) are more conservative on non-Windows so the jobs will be slower to complete... if that's how I understand this to work?

@Tobias-Fischer
Tobias-Fischer deleted the increase-linux64-batch-size branch October 8, 2026 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants