Conversation
Malionaro
marked this pull request as draft
September 17, 2026 20:27
Owner
|
Could you please retarget this PR to dev? |
Author
|
Done — retargeted to dev ✅ |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read-only audit for the disaster lifecycle after start-only replication.
DisasterEventCommand replicates one start per event; path, surge curve and actual end stay local per machine. This adds DisasterLifecycleAuditSystem tracking each event from Created until the entity is gone: start log, 60 s position/intensity heartbeat, end classification (early vs on time, lived vs commanded frames). Sends nothing, no protocol change (stays v67), runs only while the City log topic is on.
Details: session totals survive topic-off (tracking suspends and re-seeds, history kept); missing Duration logs "commanded duration unknown" instead of a fake "0 frames"; rain-driven surges excluded, like DisasterSyncSystem does.
If heartbeats agree across peers and early stays 0, start-only replication holds and no PR-B2 is needed.
Based on upstream master f0e0ad5. Developed in Malionaro#2. Needs a real multiplayer test session before merge.