Conversation
Malionaro
marked this pull request as draft
September 17, 2026 20:26
Owner
|
Could you please retarget this PR to dev? |
Malionaro
force-pushed
the
feat/service-building-state
branch
from
September 18, 2026 15:51
bd42ec9 to
e7b6dc2
Compare
Author
|
Done — retargeted to dev and rebased onto it. Service moved to Id 34 / protocol v70, still stacked on #32 — please merge that one first. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replicates Abandoned/Condemned/Destroyed markers of non-spawnable buildings: one ServiceBuildingStateCommand (new Id 34, protocol v69 -> v70) per transition, detected by a rolling 16-bucket UpdateFrame scan, realized by prefab+position match with an Updated nudge. Growables stay with GrowableSync, removals stay with DeleteSync. Seeded silently per session; dead entries pruned on a 30 s interval; own realizes suppressed via ReplicationGuard; Exists-guards on scan and match reads.
Stacked on the fire PR (#32): please merge that first. Review only the ServiceBuildingState commits; the FireIgnite commits below belong to #32.
Note: upstream dev took Ids 31/32 (brush batching) and v68 after this branch was first written, so service moved to Id 34 / v70 on top of dev.
Based on upstream dev 69cdebc. Developed in Malionaro#5. Needs a real multiplayer test session before merge.