Repository navigation
fix(config): validate STELLAR_NETWORK at boot and derive host/passphrase from it - #381
Open
testimonyblockchain wants to merge 2 commits into
Conversation
.env is read by dotenv.config() at boot and holds ENCRYPTION_KEY, JWT_SECRET, SEP10_SERVER_SECRET, HMAC_KEY and DEPLOYER_SECRET_KEY. None of the .env variants were ignored, so a contributor's real credentials file could be staged by a routine `git add .` with nothing to warn anyone. Ignore the .env variants and keep the committed example file trackable. No .env file is tracked at HEAD and no .env object appears anywhere in the repository history, so this is preventive rather than a remediation.
|
@testimonyblockchain Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Abdul-dev-creator
force-pushed
the
main
branch
2 times, most recently
from
October 18, 2026 18:47
af3277b to
a2a4455
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR validates
STELLAR_NETWORKat boot against the supported set (TESTNET,PUBLIC) and rejects anything else, then derives both the Horizon host and the network passphrase from that single validated value so they can never disagree. It removes the permissive fallback to the public network that let a typo point the passphrase at mainnet while the Horizon host stayed on testnet.Related Issue
Changes
🔒 Config Validation
src/config/env.tsSTELLAR_NETWORKagainst the supported set at boot; throw an error naming the variable and the accepted values on any unsupported input.🌐 Stellar Service
src/services/stellar.service.tsSTELLAR_NETWORKvalue.networkPassphrase()and the mismatched fallthrough in Horizon host selection, so host and passphrase can never diverge.✅ Tests
src/__tests__/stellar.service.test.tsTESTNET,PUBLIC) for host and passphrase derivation.Verification Results
src/config/env.tsnamesSTELLAR_NETWORKand the accepted valuesSTELLAR_NETWORKvaluesrc/__tests__/stellar.service.test.tsnpm testpasses locallyCloses #233