Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds an ESLint configuration to the repository and wires it into CI with a dedicated
lintjob, so lint rules are actually enforced on every pull request instead of living as unenforced preferences.Related Issue
Changes
🧹 ESLint Configuration
eslint.config.jstypescript-eslint's recommended rules.@typescript-eslint/no-explicit-anyset towarn.no-consoleset towarnforsrc/**, with overrides forsrc/config/andsrc/services/observability.service.ts.📦 Scripts
package.jsonlintscript sonpm run lintruns ESLint against the tree.package-lock.jsontypescript-eslintdependencies.⚙️ CI
.github/workflows/ci.ymllintjob that runs onpull_request, installs withnpm ci, runsnpx prisma generate, thennpm run lint.permissions: contents: readand setstimeout-minutes: 15.uses:action is pinned to a commit SHA.Verification Results
eslint.config.jsexists andnpm run lintexits zero on the current treelintjob runs onpull_requestand declarespermissions: contents: readpull_requesttrigger and read-only permissionstimeout-minutesand pins everyuses:action to a commit SHAtimeout-minutes: 15; actions pinned to SHAsnpm testpasses locallyCloses #52