[Patch][Branch Alignment] Update dev branch with test patch from PR 3214 - #3256
Merged
Merged
Conversation
Contributor
|
Current Coverage: 99% Mypy errors on dev-1.05-patch-sync branch: 1164 |
Contributor
|
🚨 Please update the changelog. This PR cannot be merged until |
Collaborator
Author
Will update this prior to merging - just trying to figure out which changelog to update for a patch duplication on |
Contributor
|
Current Coverage: 99% Mypy errors on dev-1.05-patch-sync branch: 1164 |
Contributor
|
Current Coverage: 99% Mypy errors on dev-1.05-patch-sync branch: 1164 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds code for patch in #3214 to
dev.Context
Issue(s) closed by this pull request: closes #3231
What
Fixes math in layer calculation of depth_factor. The equation was using the bottom depth of a given layer as a fixed reference instead of the layer depth itself.
####IMPORTANT NOTE: the second patch listed in the issue will be handled in a separate PR: #3237.
Why
Keeping
devandmain/testaligned.How
Simple copy-paste.
Test plan
Was tested on PR merging this exact code into
testbranch. Think simply checking that it runs here and tests pass will be adequate.Input Changes
Output Changes
Filter