Skip to content

CI-001A: repair deterministic frontend test baseline - #122

Merged
daliu merged 1 commit into
mainfrom
codex/issue-103-frontend-test-baseline-v2
Jul 13, 2026
Merged

daliu merged 1 commit into
mainfrom
codex/issue-103-frontend-test-baseline-v2

Conversation

@daliu

@daliu daliu commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Outcome

Restore a deterministic local frontend Jest baseline without contacting Firebase or changing production behavior.

Closes #103.

Scope

  • Issue: CI-001A — Repair the deterministic frontend test baseline #103 CI-001A
  • What changed: test-only Web Encoding/Streams and jsdom scroll shims; a real MPRC home-route, heading, skip-link, and target smoke test; engineering status docs that distinguish the local baseline from the still-missing required CI gate.
  • What did not change: workflows, dependencies, package locks, Firebase/Sentry/Rules code, provider configuration, the sitemap, public behavior, or deployment behavior.

Verification

  • Node v20.20.2: lockfile install completed with npm ci --legacy-peer-deps.
  • Focused App smoke: 1/1 passed.
  • Full committed frontend suite with open-handle detection: 2 suites, 16/16 passed.
  • Changed-file non-mutating ESLint with --max-warnings=0: passed.
  • Diagnostic production build with CI=true DISABLE_ESLINT_PLUGIN=true: compiled successfully.
  • git diff --check: passed.
  • Separate read-only compatibility run against preserved SAFETY-001 — Preserve callbacks and fail closed on local Firebase isolation #99 WIP: FirebaseResources/Sentry isolation suites passed 6/6. Those files are not in this branch and this is not CI-001A — Repair the deterministic frontend test baseline #103 branch coverage.
  • Independent final review: approved with no code or documentation blockers.

Existing React Router v7 future-flag and stale Browserslist warnings remain non-failing and are outside this issue.

Officer handoff

  • Officer impact: None — this changes the developer test harness and engineering status documentation only. Public pages, member/admin behavior, data, permissions, payments, deployment, and officer duties do not change.
  • Officer documentation: None — no officer-visible behavior or operating procedure changed.
  • Approving role: Platform maintainer.
  • Preview or redacted screenshot: Not applicable — no rendered product change.
  • Screenshot checked at: Not applicable.
  • Plain-language undo plan: Revert this pull request. The frontend test baseline returns to its documented pre-CI-001A — Repair the deterministic frontend test baseline #103 failure state; no production data or provider rollback is involved.
  • Deployment evidence: Local source/test/build evidence only. No website, Firebase, or provider deployment was performed or required for the branch.

Proof by surface

  • Source changed: commit bc0ca7b; two frontend test files and six engineering/status documents.
  • Tests passed: yes, locally under Node 20; counts above.
  • Code merged: not yet.
  • Website published: not yet / not relevant to the test-only change.
  • Netlify intended commit verified: not yet / not relevant.
  • runmprc.com verified: not yet / not relevant.
  • Firebase deployed: not yet / not relevant; no Firebase source or configuration changed.
  • Outside provider configured: not yet / not relevant.
  • Outside provider verified: not yet / not relevant.
  • Production behavior verified: not yet / not relevant.

Safety review

  • No secrets, recovery codes, private member data, or payment data are included.
  • The local baseline is distinguished from required CI gating, which remains NOT AVAILABLE YET under CI-001 — Establish trustworthy quality gates and protected deployment #105.
  • Skipped checks or deployments are reported as incomplete, not green/live.
  • No page, data, access, or deployment flow changed, so no diagram update is required.
  • No officer procedure changed; backup-officer workflow review is not applicable.

Residual risk

@netlify

netlify Bot commented Jul 13, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for luminous-fox-7c393f ready!

Name Link
🔨 Latest commit bc0ca7b
🔍 Latest deploy log https://app.netlify.com/projects/luminous-fox-7c393f/deploys/6a548b6325c8e700080c1936
😎 Deploy Preview https://deploy-preview-122--luminous-fox-7c393f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@daliu

daliu commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

Independent review record: two read-only subagent audits approved the test implementation; a third reviewed the expanded engineering-documentation scope. The sole lint finding (eslint-env jest) and the runbook wording finding were fixed before commit. Final exact-commit Node 20 results are 16/16 frontend tests with open-handle detection, changed-file ESLint clean, diagnostic build successful, and diff check clean. Hosted CI and the Netlify preview are green. GitHub review remains REQUIRED only because the branch author cannot approve the same GitHub identity; an admin-squash merge is being used with this recorded independent review.

@daliu
daliu merged commit bb9ae29 into main Jul 13, 2026
7 checks passed
@daliu
daliu deleted the codex/issue-103-frontend-test-baseline-v2 branch July 13, 2026 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant