Repository navigation
SEC-001: replace recursive Firestore admin access - #123
Merged
Merged
Conversation
✅ Deploy Preview for luminous-fox-7c393f ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
4 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Replaces the recursive browser-admin Firestore catch-all with explicit resource rules. Browser admins retain the minimum read access used by the current UI and may create only inert catalog drafts or change display-only catalog fields. Membership authority, event eligibility and capacity, prices, variants, waivers, payment state, audit state, secrets, operational collections, and unknown collections remain server-owned.
Fixes #100
Security invariants
Compatibility and migration
This is a Rules-only boundary change with no data migration. Existing server-configured protected fields may be carried unchanged while display fields are edited. Current browser roster, order, registration, event, and product reads remain explicit transitional access pending the scoped server-admin work. Operational admin actions remain NOT AVAILABLE YET.
Verification
git diff --check— clean.Officer impact
Officers still must not use the current Admin screens for production catalog or member changes. The guide now explains, in plain language, which display fields this source change allows and which operational or financial fields require a future reviewed server action.
Officer documentation
Updated
docs/officers/EVENTS_SHOP_MEMBERS.mdwith a short status statement, field-ownership diagram, stop conditions, success proof, undo path, and escalation role.Deployment evidence
A green source workflow is not evidence that Firebase Rules are live.