Skip to content

CI-001B1: run frontend Jest in hosted CI - #125

Merged
daliu merged 1 commit into
mainfrom
codex/issue-124-frontend-jest-ci-gate
Jul 13, 2026
Merged

daliu merged 1 commit into
mainfrom
codex/issue-124-frontend-jest-ci-gate

Conversation

@daliu

@daliu daliu commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Closes #124

Outcome

  • Run the complete committed frontend Jest suite in hosted CI immediately after the lockfile install and before the legacy mutating lint command.
  • Name the step Run frontend Jest tests so officers can verify the exact PR and merge commits.
  • Record the remaining lint, branch-protection, deployment, Firebase, and provider gaps without expanding this ticket.

Invariant and failure behavior

The Node 20 frontend job runs CI=true npm test -- --watchAll=false --runInBand. The suite is unfiltered, non-watch, serial, and has no failure masking or continue-on-error. A test failure fails the job. This does not prove that branch protection prevents a failed merge.

Verification

  • Node 20.20.2 lockfile install: passed
  • Exact complete frontend command: 2 suites and 16 tests passed
  • Temporary intentional failure probe: command exited 1; probe removed before commit
  • Diagnostic production build: compiled successfully
  • Workflow YAML parse: passed
  • git diff --check: passed
  • Two independent read-only agent reviews: approved

The exact pull-request and post-merge hosted executions of the named step remain required closure evidence.

Scope and residual risk

No package, lockfile, deploy workflow, Firebase, Functions, Rules, Stripe/provider configuration, application source, or public asset changed. Existing mutating/fail-open lint, unproven branch protection, independent deploy ordering, known dependency findings, React Router warnings, and stale Browserslist data remain open under the tracker and supply-chain work.

Officer handoff

Officer impact: Officers get one named frontend-test step to check before and after merge, plus explicit warnings that it is not lint proof, branch-protection proof, or proof that any live surface changed.

Officer documentation: OFFICER_START_HERE.md, docs/officers/PUBLISH_AND_CHECK.md, and docs/officers/GLOSSARY.md.

Deployment evidence: Website source is changed on this branch and the local diagnostic build passed; nothing is merged or published yet. Firebase was not changed or deployed. No outside provider was changed or configured. PR, merge-commit, GitHub Pages, Netlify, and runmprc.com evidence will be recorded separately as applicable.

Undo

Revert this focused commit through a reviewed pull request. That removes the Jest workflow step and restores the matching documentation; it does not alter member, payment, Firebase, or provider data.

@netlify

netlify Bot commented Jul 13, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for luminous-fox-7c393f ready!

Name Link
🔨 Latest commit a6b8566
🔍 Latest deploy log https://app.netlify.com/projects/luminous-fox-7c393f/deploys/6a5492d12517bb0008781acc
😎 Deploy Preview https://deploy-preview-125--luminous-fox-7c393f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@daliu

daliu commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

Independent review and PR-run evidence for commit a6b85664f33ca8bf4bf83a6196f7a64958634e13:

  • Two separate read-only Codex review agents approved the final diff. One review initially caught the unsafe test-after-lint ordering; the step was moved immediately after npm ci, the officer truth/glossary gaps were fixed, and both reviewers then reported no remaining blocker.
  • Hosted PR run 29232008242 completed successfully.
  • Frontend job 86758114071 shows Run frontend Jest tests as step 5, successful, before the legacy lint command at step 6.
  • The named step log reports 2/2 suites and 16/16 tests passed and Ran all test suites.
  • Hosted Functions and Firestore Rules jobs passed. The Netlify deploy preview passed; its header/page-change checks were skipped because this ticket changes no generated website page.

This is independent agent review, not human approval. Branch protection remains unproven and the legacy lint command remains mutating/fail-open, as documented and left to CI-001B2.

@daliu
daliu merged commit f04b89a into main Jul 13, 2026
7 checks passed
@daliu
daliu deleted the codex/issue-124-frontend-jest-ci-gate branch July 13, 2026 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant