Repository navigation
chore: remove unused gpxparser chain - #130
Merged
Merged
Conversation
✅ Deploy Preview for luminous-fox-7c393f ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
INDEPENDENT EXACT-COMMIT REVIEWS —
No review blocker remains. Merge is still blocked on the exact pull-request hosted checks and release evidence. |
Contributor
Author
|
EXACT-HEAD HOSTED EVIDENCE —
Merge remains the next controlled transition. Post-merge CI, GitHub Pages, production Netlify, |
9 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #127.
Outcome
Remove the unused direct
gpxparserdependency and only the lockfile entries that become unreachable. The tested website behavior and optimized production asset hashes are unchanged.Officer impact: No member or officer workflow changes. Officers should see the same pages and navigation; the website build has a smaller production dependency graph.
Officer documentation: None — this dependency/lockfile cleanup changes no public content, navigation, collected data, permissions, accounts, payments, deployment duties, recovery procedure, or officer workflow.
Deployment evidence: PR head
c747564ab6ad2695e768a15d8b24a94d7cab8941passed run29235020205and merged as91f834dc7e33eb36b34f520544f9fd7d00810d8e. Post-merge run29235228183passed frontend Jest 47/47, build, Functions, and Rules. Deploy run29235228098rebuilt/published the byte-identical GitHub Pages artifact and correctly found nothing new to commit. Netlify production deploy6a54a055f0b97c000829980ais ready for the exact merge commit; its immutable response andrunmprc.comboth return HTTP 200 with identical index hashes/assets. Firebase explicitly skipped becauseFIREBASE_SERVICE_ACCOUNTis absent; outside providers were unchanged.Invariant and compatibility
gpxparser@3.0.8, which pulls an obsoletejsdom@15/request/form-datachain.gpxparseris absent; no replacement dependency is added.Lockfile and security evidence
npm ci --legacy-peer-depsinstalls 2,155 packages successfully.npm ls gpxparser --allreturns the expected empty tree.version,resolved, orintegrityfield changes. Shared entries only become development-only after the obsolete production path disappears.npm audit --omit=dev: 33 → 22 total; critical 3 → 1; high 9 → 8; moderate 20 → 12; low remains 1. Production dependencies fall from 686 → 590.Verification
CI=true npm test -- --runInBand— 4 suites, 47/47 tests passed.npm run test:spa-navigation— 10/10 tests passed.CI=true DISABLE_ESLINT_PLUGIN=true npx --no-install react-scripts build— compiled successfully.main.58ede287.js,main.cdd8bda4.css, and962.0a706e83.chunk.js; all other emitted content-hash names also match.git diff --check— passed.gpxparserimport or use outside the removed manifest entry and tracking/security records.Review and release
c747564ab6ad2695e768a15d8b24a94d7cab8941with no blockers. One independently reproduced the lock reachability and audit delta; the other also confirmed the pre/post build directories are byte-identical.29235020205passed frontend Jest 47/47, frontend build, Functions, and Rules; the Netlify preview is ready and returns HTTP 200 with the unchanged asset hashes.29235228183passed frontend Jest 47/47, frontend build, Functions, and Rules.29235228098passed. GitHub Pages generated no new commit because the artifact is identical; Netlify deploy6a54a055f0b97c000829980ais ready at exact merge commit91f834dc7e33eb36b34f520544f9fd7d00810d8e; its immutable URL andrunmprc.comreturn matching HTTP-200 content.FIREBASE_SERVICE_ACCOUNTwas absent. Provider configuration remained unchanged.