Repository navigation
PROMO-001: disable unmodeled Stripe adjustments - #144
Merged
Merged
Conversation
✅ Deploy Preview for luminous-fox-7c393f ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
5 of 6 tasks
Contributor
Author
|
POST-MERGE EVIDENCE
No protected release was requested. Firebase and Stripe were not changed or read back, the current protected plan does not name these three Stripe Functions, and production behavior remains unverified. |
This was referenced Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
New race and merchandise Checkout Sessions no longer accept Stripe promotion codes or automatic tax. The signed webhook now refuses incomplete, malformed, inconsistent, overflowing, or nonzero discount/tax/shipping breakdowns instead of treating them as valid payments.
This is source safety only. Live commerce remains unavailable.
What changed
allow_promotion_codes: falseandautomatic_tax.enabled: falsein both current Checkout creatorsschemaVersion: "1"metadata to new Sessions and PaymentIntents while preserving legacy metadata compatibilitytotal_detailsand presentshipping_costcomponent shapesSafety invariants
Verification
v20.20.2npm --prefix functions run lint— passednpm --prefix functions run test:run -- --runInBand— 159 passed; 1 emulator-only test skippedgit diff --cached --check— passed391778bcfb54df137a2e5cb1ff9959a91e153bd99558658c7166eb0757a589c9Remaining work
createCheckoutSession,createMerchCheckout, andstripeWebhook.Officer impact: Officers must keep live race/shop checkout unavailable and must not create website promotion, tax, or shipping configuration. The guide now provides a short stop-and-escalate path.
Officer documentation:
docs/officers/EVENTS_SHOP_MEMBERS.mdDeployment evidence: Website not published; Firebase not deployed; Stripe/provider settings not changed or verified; production behavior not verified. Source commit only:
f944aaffb1eff745b708ea53d1e15f71bc401d0e.Source work for #102; do not auto-close the issue.