Skip to content

AUTH-MAIL-002A: report verification-email request outcome truthfully - #148

Merged
daliu merged 1 commit into
mainfrom
codex/issue-145-registration-email-truth
Jul 13, 2026
Merged

daliu merged 1 commit into
mainfrom
codex/issue-145-registration-email-truth

Conversation

@daliu

@daliu daliu commented Jul 13, 2026 •

Copy link
Copy Markdown
Contributor

Closes #145

Outcome

Registration now reports two separate facts: whether the account was created and whether Firebase accepted the verification-email request. If the second step fails, the signed-in account is preserved, no provider detail is exposed, and the member receives one safe inspection/stop path instead of a false Inbox claim.

State transitions

Result Member message System behavior
Account creation fails Generic account-creation error No success state
Account created; email request accepted Account exists; request accepted; delivery is not guaranteed Signed-in account remains; Inbox/Spam suggestion allowed
Account created; email request fails Account exists; request did not finish Signed-in account remains; no retry, navigation, or access grant

Safety and compatibility

Verification

  • Node 20 focused identity/login/diagnostic tests: 44/44 passed.
  • Full frontend tests: 9 suites, 113/113 passed.
  • SPA navigation tests: 10/10 passed.
  • Strict changed-file lint: passed.
  • Optimized diagnostic build: passed.
  • Relative links, sensitive-pattern scan, and git diff --check: passed.
  • Synthetic local browser check: desktop and 390px layouts passed; action height is 48px; no production mailbox/provider was used.
  • Two independent exact-diff reviews approved security/correctness and officer/usability/accessibility with no findings.

Officer handoff

Officer impact: Members see account creation and email-request acceptance separately. If the request fails, they keep the account and receive a safe stop/escalation message.

Officer documentation: docs/officers/EVENTS_SHOP_MEMBERS.md; docs/officers/EMERGENCY_AND_RECOVERY.md.

Deployment evidence: Source commit 7c66602 and local tests are proven. Code merge, website publication, runmprc.com, Firebase deployment, provider configuration, and production behavior are not yet proven. No production email was sent.

Rollback

Revert this pull request. There is no data migration or provider configuration to undo.

Post-merge release result

  • Squash merge: 46557c7988a496c1081e268baad6f33fb186ee0f.
  • Exact post-merge CI run 29247002544: passed.
  • Protected production release run 29247125844: exact-main/CI preflight passed, then failed closed because required public App Check build configuration is absent.
  • Website build, Firebase authentication/deployment/readback, and Pages publication: skipped.
  • runmprc.com: HTTP 200 on 2026-07-13, but still served prior asset main.58ede287.js; the new registration copy is not live.
  • Provider configuration and production behavior remain unproven. No production email was sent.

@netlify

netlify Bot commented Jul 13, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for luminous-fox-7c393f ready!

Name Link
🔨 Latest commit 7c66602
🔍 Latest deploy log https://app.netlify.com/projects/luminous-fox-7c393f/deploys/6a54cde26c4a3700081d1c3e
😎 Deploy Preview https://deploy-preview-148--luminous-fox-7c393f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@daliu
daliu merged commit 46557c7 into main Jul 13, 2026
7 checks passed
@daliu
daliu deleted the codex/issue-145-registration-email-truth branch July 13, 2026 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AUTH-MAIL-002A — Tell the truth when account creation succeeds but verification sending fails

1 participant