Repository navigation
CONFIG-001A: fail closed on unsafe server configuration - #150
Merged
Merged
Conversation
✅ Deploy Preview for luminous-fox-7c393f ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This was referenced Jul 13, 2026
Closed
Contributor
Author
|
Post-merge evidence: squash commit 2c62b8d; exact main-push CI run 29248650885 passed all required frontend, Functions, and Rules jobs. Firebase deployment was not attempted because the only reviewed workflow plan is profile-recovery and does not include this PR Function set; the required protected production/public configuration is also absent. Website, Firebase, Stripe provider state, payment, email, and production behavior remain unproven. |
11 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #149
Outcome
Current checkout, admin-commerce, webhook, and confirmation-mail entry points now require one typed server configuration at each invocation. Missing or mismatched settings stop with a fixed nonsecret result before rate-limit, business-data, mail, event-ledger, or Stripe side effects.
Safety boundary
Verification
Rollout and rollback
This source is safe only when the protected environment supplies the documented settings. Revert this PR to roll back source. Never restore a default production website address. Firebase parameters, Secret Manager bindings, Stripe provider mode, and protected deployment require separate private evidence.
Officer impact: Releases with missing or mismatched server settings stop before registrations, orders, refunds, mail, or Stripe work. Officers never handle or copy a Stripe key.
Officer documentation: docs/officers/PUBLISH_AND_CHECK.md
Deployment evidence: Source and local tests only at PR creation. Firebase deployment, website publication, Stripe or Firebase provider configuration, and production behavior are unproven. No production payment, email, member data, secret, or provider setting was used.