Repository navigation
CI-001B3: gate command journal Firestore transactions - #168
Merged
Merged
Conversation
✅ Deploy Preview for luminous-fox-7c393f ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This was referenced Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #167
Outcome
Adds one blocking
Commerce command journal emulatorCI job. Every pull request and main push now runs the PAY-002B2A transaction suite against exact Firebase demo projectdemo-pay002b2-testwith Firestore only. The protected release workflow requires exactly one successful result for that job during initial preflight and again after protected approval.This closes the hosted-verification gap recorded by #165 before lease/fencing work begins.
Safety boundary
npx --no-install.continue-on-error, shell failure swallowing, wrong/broad emulator wiring, unlocked CLI use, and omission or relocation from either release recheck.Verification
Compatibility and rollback
No runtime, API, schema, package, lockfile, provider, or production-data change. Rollback is the reviewed workflow/documentation commit, but removing this job reopens a known concurrency-verification gap and must not be silent.
Officer impact: Pull requests gain one named green/red payment-safety check. Officers do not run commands or handle secrets.
Officer documentation:
OFFICER_START_HERE.mdanddocs/officers/PUBLISH_AND_CHECK.mdname the check, explain its made-up test data, and keep merge/release/live states separate.Deployment evidence: Source and local synthetic evidence only before merge. This pull request deploys no Firebase code, contacts no Stripe/provider service, publishes no website, and claims no live behavior.