Repository navigation
WEB-UX-001 — Keep fixed navigation from covering page content - #171
Merged
Merged
Conversation
✅ Deploy Preview for luminous-fox-7c393f ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
Independent exact-head review completed for
|
Contributor
Author
|
Hosted verification for exact head
This verifies the preview only. It does not prove a merge, production publication, Firebase deployment, or a change on runmprc.com. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #170
Outcome
Pages with and without image banners now reserve the same fixed-navigation height, so the first heading or hero begins below the navigation instead of underneath it. No placeholder images, route components, account code, or content changed.
Layout invariant
--site-nav-height: 5.5remis the single height source.navconsumes that value.#main-contentreserves that value.Verification
git diff --check: passed./eventsand/shop: nav bottom 88px, route root 88px, heading 104px./activities: route root 88px with no doubled top gap./events,/shop, and/activities;/#main-contenttarget: first route content began at 88px, equal to nav bottom.The local Events and Shop data requests intentionally remained fail-closed without production member data; layout was verified around their visible error/loading surface only.
Scope and safety review
Claimed paths only:
src/index.csssrc/components/navbar.csssrc/pages/home/home.csssrc/headerClearance.test.jsNo Auth, Account, route component, Firebase, Functions, Rules, commerce, provider, workflow, image, or
public/sitemap.xmlchange.Officer handoff
be08855.runmprc.comverified with this change: no.Undo
Revert the single merge commit in a reviewed pull request. This restores the old CSS offsets; no data or provider rollback is involved.