Skip to content

WEB-UX-001 — Keep fixed navigation from covering page content - #171

Merged
daliu merged 1 commit into
mainfrom
codex/issue-170-header-content-offset
Jul 13, 2026
Merged

daliu merged 1 commit into
mainfrom
codex/issue-170-header-content-offset

Conversation

@daliu

@daliu daliu commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Closes #170

Outcome

Pages with and without image banners now reserve the same fixed-navigation height, so the first heading or hero begins below the navigation instead of underneath it. No placeholder images, route components, account code, or content changed.

Layout invariant

  • --site-nav-height: 5.5rem is the single height source.
  • The fixed nav consumes that value.
  • #main-content reserves that value.
  • Shared hero and Home no longer add old route-specific top margins.

Verification

  • Focused regression first failed on the baseline, then passed: 2/2.
  • Full frontend Jest: 10 suites, 134 tests passed.
  • SPA callback safety: 10/10 passed.
  • Strict changed-file ESLint: passed with zero warnings.
  • git diff --check: passed.
  • Diagnostic production build with Node 20: compiled successfully.
  • Browser at 1280x720:
    • /events and /shop: nav bottom 88px, route root 88px, heading 104px.
    • Home and /activities: route root 88px with no doubled top gap.
  • Browser at 390x844:
    • same 88px shared clearance on Home, /events, /shop, and /activities;
    • mobile menu opened and navigated successfully.
  • 640px effective-width / 200%-zoom-equivalent check: route root remained at 88px and hamburger navigation was present.
  • Exact /#main-content target: first route content began at 88px, equal to nav bottom.

The local Events and Shop data requests intentionally remained fail-closed without production member data; layout was verified around their visible error/loading surface only.

Scope and safety review

Claimed paths only:

  • src/index.css
  • src/components/navbar.css
  • src/pages/home/home.css
  • src/headerClearance.test.js

No Auth, Account, route component, Firebase, Functions, Rules, commerce, provider, workflow, image, or public/sitemap.xml change.

Officer handoff

  • Officer impact: page titles and controls are visible below navigation on computer and phone-sized screens.
  • Officer documentation: None — no officer procedure, navigation destination, permission, collected data, public wording, or deployment duty changed.
  • Deployment evidence:
    • Source changed: commit be08855.
    • Tests passed: local evidence above; hosted CI pending.
    • Merged: no.
    • Website published: no.
    • runmprc.com verified with this change: no.
    • Firebase deployed: not relevant; no backend change.
    • Outside provider configured or verified: not relevant.

Undo

Revert the single merge commit in a reviewed pull request. This restores the old CSS offsets; no data or provider rollback is involved.

@netlify

netlify Bot commented Jul 13, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for luminous-fox-7c393f ready!

Name Link
🔨 Latest commit be08855
🔍 Latest deploy log https://app.netlify.com/projects/luminous-fox-7c393f/deploys/6a5523586e373e00083c081e
😎 Deploy Preview https://deploy-preview-171--luminous-fox-7c393f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@daliu

daliu commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

Independent exact-head review completed for be08855f53c6d82522d99023fc93902b767825e0.

  • Code/scope review: approved, no findings.
  • QA/release review: approved, no findings.
  • Confirmed only the four claimed CSS/test paths changed.
  • Confirmed the shared clearance, legacy-margin removal, skip-target compatibility, mobile-menu behavior, browser coverage, and no officer-document impact.
  • Merge condition remains: all hosted checks pass and the branch still matches current main. Production publication and runmprc.com verification remain separate after merge.

@daliu

daliu commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

Hosted verification for exact head be08855f53c6d82522d99023fc93902b767825e0 is complete.

  • GitHub Actions run 29271460353:
    • Frontend lint + build: passed
    • Cloud Functions lint + test: passed
    • Firestore security-rules tests: passed
    • Commerce command journal emulator: passed
  • Netlify deploy preview: passed at https://deploy-preview-171--luminous-fox-7c393f.netlify.app
  • Exact preview /events geometry:
    • 1280x720: nav bottom 88px, route root 88px, heading 104px
    • 390x844: nav bottom 88px, route root 88px, heading 104px
  • Netlify Header rules and Pages changed checks skipped because this PR changes neither surface; Redirect rules passed.

This verifies the preview only. It does not prove a merge, production publication, Firebase deployment, or a change on runmprc.com.

@daliu
daliu marked this pull request as ready for review July 13, 2026 17:44
@daliu
daliu merged commit 5732e5a into main Jul 13, 2026
8 checks passed
@daliu
daliu deleted the codex/issue-170-header-content-offset branch July 13, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WEB-UX-001 — Keep fixed navigation from covering page content

1 participant