Repository navigation
CI-001B4: make frontend lint non-mutating and fail closed - #189
Merged
Merged
Conversation
✅ Deploy Preview for luminous-fox-7c393f ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
13 tasks done
This was referenced Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Replaces the mutating, ignored frontend lint line with a direct, blocking, non-mutating gate. The reviewable baseline records all 102 frontend files and all 125 configured errors plus 7 warnings after disabling the repository-wide severity-masking hook inside this process.
Closes #186
Parent: #105
Security invariant
ubuntu-latest, read-only permission, credential-free checkout, Node 20, lifecycle-disabled install, lint, then clean verificationEvidence on exact head
0bb164904fb6a8352c6141fc44ff7cd30425e750Local Node 20:
frontend_lint_gate_failed:lint_rejected, probe removedHosted pull-request run 29291402007:
Run npm ci --legacy-peer-deps --ignore-scripts: passedRun non-mutating frontend lint: passedVerify frontend lint left the checkout unchanged: passedBoundaries
Officer impact: None — this is an engineering quality gate and changes no officer task or public behavior.
Officer documentation: None — no officer procedure changes.
Deployment evidence: Source, local tests, hosted PR CI, and a disposable Netlify PR preview only. No production website publication, Firebase deployment, Stripe/provider change, branch-protection change, or production behavior is claimed. Post-merge hosted evidence remains pending.