Skip to content

DATA-001C2: stop Auth phone copy during profile setup - #199

Merged
daliu merged 1 commit into
mainfrom
codex/issue-197-stop-auth-phone-copy
Jul 14, 2026
Merged

daliu merged 1 commit into
mainfrom
codex/issue-197-stop-auth-phone-copy

Conversation

@daliu

@daliu daliu commented Jul 14, 2026 •

Copy link
Copy Markdown
Contributor

Closes #197

Outcome

New member profiles keep the existing schema-compatible empty phone field even when Firebase Auth already contains a phone number. The shared create-once helper still serves both signup and callable recovery, and every existing profile remains unchanged.

Security and compatibility

  • The helper no longer reads, normalizes, truncates, returns, or logs user.phoneNumber.
  • Signup and recovery use the same transactional create-only path.
  • Existing profiles, roles, claims, and stored phone values are not read for migration, overwritten, cleared, exported, or deleted.
  • No Rules, provider, package, workflow, production-data, roster, event, shop, or deployment surface changes.
  • There is no data migration. Rollback is one reviewed revert or safe roll-forward of the helper/tests/docs through the backend-first gate.

Verification

  • Red proof before the fix: focused suite failed 4 phone-copy assertions.
  • Focused Functions unit tests: 21/21 passed on Node 20.
  • Real Firestore emulator concurrency test: 1/1 passed with demo-only Auth/Firestore emulators and Java 17.
  • Full Functions suite: 991 passed; 32 unrelated emulator-only tests skipped.
  • Functions lint: passed.
  • Frontend suite: 198/198 passed.
  • Post-AUTH-001B — Require verified email for role-based Firestore access #196 Firestore Rules emulator suite: 348/348 passed.
  • SPA plus emitted-artifact safety checks: 33/33 passed.
  • Diagnostic production build: passed without sitemap generation.
  • git diff --check: passed.
  • Rebased onto AUTH-001B — Require verified email for role-based Firestore access #196 merge a880177; exact DATA-001C2 — Stop profile setup from copying Firebase Auth phone numbers #197 diff SHA-256 stayed 2961034bb3a6f7f76b4942702ed3a5b4aefbf43709ed0e3d12b1dbd4bfbde6ae.
  • Independent security/privacy and backup-officer/QA reviews approved that exact diff.
  • Production audits remain at the documented baseline: root 19 vulnerabilities (1 critical, 5 high) and Functions 9 (1 high); this PR changes no dependency or lockfile.

Officer handoff

Officer impact: New signup/profile repair will not copy a Firebase Auth phone into the member profile after the backend is deployed. Officer steps remain no-phone, synthetic-data-only, and stop-and-escalate.

Officer documentation: docs/officers/EVENTS_SHOP_MEMBERS.md; engineering flow/status in SYSTEM_DESIGN.md.

Deployment evidence: Source/tests and this pull request only. No website was published; runmprc.com was not changed or verified; Firebase Rules/Functions were not deployed or read back; no provider setting or production record was accessed. Live protection remains NOT AVAILABLE YET until #105/#133/#136 deploy and verify the exact Rules plus both profile Functions before any dependent website revision.

@netlify

netlify Bot commented Jul 14, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for luminous-fox-7c393f ready!

Name Link
🔨 Latest commit 84fb10d
🔍 Latest deploy log https://app.netlify.com/projects/luminous-fox-7c393f/deploys/6a5588a6a338330008e70fc1
😎 Deploy Preview https://deploy-preview-199--luminous-fox-7c393f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@daliu
daliu force-pushed the codex/issue-197-stop-auth-phone-copy branch from 1e95662 to 84fb10d Compare July 14, 2026 00:53
@daliu
daliu merged commit 3f36a64 into main Jul 14, 2026
9 checks passed
@daliu
daliu deleted the codex/issue-197-stop-auth-phone-copy branch July 14, 2026 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DATA-001C2 — Stop profile setup from copying Firebase Auth phone numbers

1 participant