Repository navigation
MEMBERS-DIRECTORY-001D: add a safe frontend-only directory preview - #622
Merged
Merged
Conversation
✅ Deploy Preview for luminous-fox-7c393f ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
8 tasks
Contributor
Author
|
Final review on exact head
The repository requires a GitHub-account review that the author cannot submit. Under the user's explicit authorization to review and merge, the three independent reviews above and exact green gates support an administrator squash merge. The claim stays active through exact-main CI and deployment/readback audit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Adds a truthful frontend-only preview for the optional profile photo, independent People finder choice, and officer People finder while keeping every directory backend path unavailable by default.
/admin/member-directoryremains behindAdminGuardand shows a disabled name field and Search button.false; it is UI routing only, never authorization.Closes #621.
Safety boundary
Invariant: a frontend preview must not imply saved consent or accept private input before the backend/privacy/release gates exist.
Failure behavior: controls stay disabled and visibly described. Missing display name adds future-prerequisite copy but never enables the choice. The officer route retains its ordinary authentication/role guard but obtains no member-directory service context in preview mode.
Migration impact: none. No schema, Rules, index, Function, provider, data, environment, dependency, or workflow change. #507 still owns privacy approval, scoped authorization, isolated staging, backend/index deployment and readback, projection repair/backfill proof, and the later reviewed availability flip.
Verification
npm run lint:ci— 120 files; unchanged 113 reviewed legacy errors / 6 warningsgit diff --check— passedOnly synthetic local Auth/Firestore/Functions emulators were used for protected-layout QA. No production sign-in, real name/photo, production data, or provider action was used.
Officer impact
Officer impact: Officers can review an inert People finder layout and its future privacy boundaries in synthetic local evidence. They cannot search a name, view a person, or use the directory.
Officer documentation:
OFFICER_START_HERE.md,docs/officers/README.md, anddocs/officers/EVENTS_SHOP_MEMBERS.md; matching architecture/security/implementation/operations current-truth sections are also updated.Deployment evidence: Website — not yet published by this pull request; production remained on the known-good bounded #473 Netlify deploy during the pre-PR audit. Firebase — unchanged and not deployed. Outside providers and production data — unchanged. Connected behavior and live directory — not performed and remain NOT AVAILABLE YET.
Exact candidate
3cf3e5bfc3ee13b084edb6efb8eff6bb21b907c51c9f463bfe72b189d5f64e38643f45a5d73ab29fe403c15f6588ea9ed4ecb5cb958b33ce4e6c4768daba9d6e4e2942617f6d21036ddf3cb23f1cbad2c157b7398551b31a2bfe8c46