Repository navigation
Conversation
✅ Deploy Preview for luminous-fox-7c393f ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
7 tasks
Officer impact: No live change; documents disabled daily suggestions and privacy controls.\nOfficer documentation: docs/officers/RUNNER_CONNECTIONS.md\nDeployment evidence: source/emulators only; website, Firebase and providers unchanged.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build opt-in runner connections for MPRC so members can find compatible running partners and occasionally broaden their circle. Related to #689; keep this PR draft and the feature disabled until the remaining integration and privacy requirements are complete.
Behavior
Integration and release boundary
The branch incorporates current main and Node 22 PR #692 at merge commit
183278803cd5e5c29b578d5974bba892dc80c247. Both security records are preserved. The test-only HTTP harness now matches the parent Node 22 engine, with a drift regression test; runner CI mutation fixtures are scoped to their own job. All six required CI jobs and both protected-release checks remain intact.No runner handler is imported/exported by the production Functions index. The UI source gate remains false. This PR adds no dependency resolution, membership writer, real-data backfill or payment change relative to current main. It does not widen the existing two-profile-Function release scope.
Before a pilot: complete canonical membership population and UID uniqueness (#81/#114/#115), bounded persistent privacy-choice management, consent/retention/account-deletion approval, normal app sign-in/service-locator integration, hosted cryptographic Auth/App Check and CORS verification, and protected release prerequisites. A limited sample is not an exhaustive club search; point-in-time checks cannot recall delivered data.
Validation
Latest local combined-source checks:
Exact-head CI 36496834485 passed all six jobs on
1832788. Job details/logs confirm 1,384 frontend tests, 468 Rules tests, 107 runner-emulator tests, 140 contract checks, 63 commerce-journal tests, optimized build and artifact verification executed successfully. The Node 22 integration job passed 7,777 cases with only the 63 separately tested commerce cases skipped. The preserved Node 20 Rules job ran all 8 HTTP tests with zero skips; its emulator used the Node 20 host despite the Node 22 manifest. The separate local HTTP run above used Node 22. No hosted-runtime or deployment claim follows from either.Separate September 27 browser rehearsal used actual RunnerWorkspace/client with synthetic local Auth/Functions/Firestore: save/reload, phone suggestion/block/undo, withdrawal/reload and nonmember denial passed. No phone overflow or captured console warnings/errors. Normal zero-record cleanup and emulator shutdown were verified; forced interruption remains unproven. This is local integration evidence, not normal app login, hosted token verification or a live feature. Historical evidence and limits are preserved in
docs/RUNNER_CONNECTIONS.md; existing dependency advisories remain unresolved.Officer impact: No live change; runner connections remain NOT AVAILABLE YET.
Officer documentation:
docs/officers/RUNNER_CONNECTIONS.md, handbook link,docs/RUNNER_CONNECTIONS.md, and corresponding root design/security/operations records.Deployment evidence: Source and tests updated; this PR is not merged to main. No website release, Firebase deployment, outside-provider change or production behavior verification. An automatic PR preview is not a connected member service. Existing #113/#133/#136 release and billing prerequisites remain separate.