Repository navigation
fix: explicit v1 staging context and no-retry verification - #703
Merged
Merged
Conversation
✅ Deploy Preview for luminous-fox-7c393f ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
daliu
changed the title
Contributor
Author
|
Maintainer re-review: actual hosted error was missing GCLOUD_PROJECT before the profile handler; the correction supplies only the fixed staging context. Verified empty FailurePolicy is no retry; retry:{} still rejects. Repair admission requires the exact initial signup source and unchanged bundle digest, with no secret/foreign project admitted; never accepts that state as completed proof. Latest head c476034 passed all six jobs in 38176343356 and 16 local release regressions. Same permissions, dependencies and profile logic; no production fallback. Officer guide records partial state; hosted proof still pending on #701. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #701; follow-up to #702. Run 38175760640 built/activated signup but failed the no-retry readback before callable deployment. The first made-up hosted signup then exposed the v1 SDK's missing GCLOUD_PROJECT context before any profile write. No broad permissions or production fallback were used.
Correction: decode only absent/empty failurePolicy as no retry (retry: {}, unknown fields, arrays/null still reject); supply only GCLOUD_PROJECT=run-mprc-staging alongside explicit staging FIREBASE_CONFIG. Repair admission accepts only the known partial initial signup source 3edffdf and unchanged bundle digest, not a foreign source/bundle/project/secret or completed hosted proof. Full successful readback still requires all settings. Profile logic, permissions, dependencies and Auth/App Check are unchanged.
Checks: 16 focused release tests passed; all six CI jobs required for the latest head and exact merged main again. Initial synthetic signup failure remains honest pending proof; both actual Functions and fresh signup/recovery must pass.
Officer impact: accurate staged resource verification and correct explicit SDK context; no broader role or retry behavior.
Officer documentation: docs/officers/LOW_COST_COMMUNITY.md records the partial state and narrow repair.
Deployment evidence: only initial signup ACTIVE; callable not deployed; hosted signup did not pass yet. Production, payments and website untouched.