Repository navigation
Reject non-object staging officer event drafts before database work - #713
Merged
Merged
Conversation
✅ Deploy Preview for luminous-fox-7c393f ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
Self-reviewed: unconditional typed draft parsing now rejects null/false/zero/string/array before DB work for both create/edit. No state, permissions, provider, docs procedure or baseline changed. Focused46 cases and all six exact-head jobs/steps pass in38193915451. User sole-maintainer merge/staging-release authorization applies; actual deployment still pending #711. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Officer impact: Malformed event drafts are rejected at the input boundary; no officer-visible workflow changes.
Officer documentation: None — this preserves the already documented exact typed event form and changes no steps, fields, access or provider behavior.
Deployment evidence: No release yet; source-only follow-up before #711 staging rollout. No production/real data/payments.
Review found null/false/zero event values could skip the draft parser. Subsequent event validation prevented writes, but these should be invalid-argument before service/DB work. Make parsing unconditional for create/edit and add five table cases across both actions. No baseline, dependency, schema migration, permission or Function/resource change.
Focused backend and lint pass. Refs #711; stage deployment will use the final green exact-main source, so no redundant Function build.