Skip to content

RACE-SIM-001C: Prepare private fictional race staging member screen - #734

Merged
daliu merged 2 commits into
mainfrom
codex/fictional-race-member-screen
Oct 13, 2026
Merged

daliu merged 2 commits into
mainfrom
codex/fictional-race-member-screen

Conversation

@daliu

@daliu daliu commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Outcome

Prepare a small staging-only fictional race member screen. It uses the existing community callable; no payment provider, new service, dependency, workflow or runtime permission is added. Related to #731; this PR does not close hosted acceptance.

Officer impact: Planned supervised signup, fictional full credit return and private recipient-accepted bib transfer. NOT AVAILABLE YET until native staging release/security/screens/cleanup are verified. No real refund or club rule is implied.
Officer documentation: OFFICER_START_HERE.md, docs/officers/README.md, STAGING_COMMUNITY.md, EVENTS_SHOP_MEMBERS.md, SYSTEM_MAPS.md, and relevant root status. The planned procedure names Dave, prerequisites, stop/proof/undo and specialist-only setup/release/cleanup.
Deployment evidence: None from this PR at source review. The prior #724 staging deployment is historical. New native race archive, backend-first Hosting, genuine caller/App Check/security, actual disposable screens/mobile and fenced cleanup remain #731 gates. Production and real payments are untouched.

Safety and compatibility

  • Exact plain-object/array parsing, bounded IDs/enums/time/credits, no extra response fields or client amount/deadline/role override.
  • Same Auth/Functions app, explicitly enabled staging, verified disposable SDK caller and default tenant. Native server still decides authority/state/time; no token extraction or browser-admin trust.
  • Account/session/provider generation fences, including same-UID credential renewal, discard late private results and clear saved actions.
  • Failed/uncertain reads hide old controls. Retry preserves exactly the original command/UUID; successful status alone restores current choices. Consumed acceptance rereads own status with no old incoming offer ID.
  • Conservative known-deadline clearing, no polling; no runner/offer directory, email or direct database write.
  • Fictional waiver/credits only, original credit owner retained. One enrollment ever/one transfer are test limits, not real policy.
  • Additive route/link only; existing membership/free-event/officer/profile code and Functions/Rules/package/workflow remain unchanged. No stored schema migration or backfill.
  • Lint baseline adds five scanned files only. Zero new findings; the existing 113 errors/six warnings and all finding records are unchanged. No lint rule or severity is weakened.
  • CI's file-count test is updated from 126 to 131, with an explicit zero-finding assertion for each of the five new files. The first PR run caught the stale count; local reproduction confirmed it. No workflow/gate is bypassed, and that failed run is not acceptance.

Local proof

  • Full frontend: 23 suites / 1,461 passed before the final two added test cases.
  • Final focused race client/screen: 78 passed, including disabled feature/production/split app/tenant, malformed and hostile DTOs, signup/cancel/offer/accept/revoke, immutable uncertain retry, session/account/provider switch, failed status, cancelled-event history, expired incoming/owner revoke, deadline/no polling and UUID failure.
  • TypeScript, exact lint gate, Functions lint and whitespace checks pass.
  • Existing release/Hosting contract tests: 37 passed; provider calls are doubles, not native proof.
  • Synthetic staging diagnostic build passed in one owned artifact folder, without changing sitemap/current rollback build. It was not published or used with credentials.

Review: checked actual client/state flow for closed bounds, caller/context privacy, retry binding, stale/deadline handling, no secret/body logging, no direct server-only writes and no production/payment fallback. Six exact PR/main jobs and every step must pass before source merge/release. #731 remains open for genuine hosted acceptance and exact disposable cleanup.

@netlify

netlify Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for luminous-fox-7c393f ready!

Name Link
🔨 Latest commit f1bb18e
🔍 Latest deploy log https://app.netlify.com/projects/luminous-fox-7c393f/deploys/6ace867e9e4507298de37d4f
😎 Deploy Preview https://deploy-preview-734--luminous-fox-7c393f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@daliu
daliu merged commit 669e2fb into main Oct 13, 2026
10 checks passed
@daliu
daliu deleted the codex/fictional-race-member-screen branch October 13, 2026 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant