Repository navigation
RACE-SIM-001C: Retain selected offer and record staging deployment - #735
Merged
Merged
Conversation
✅ Deploy Preview for luminous-fox-7c393f ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
daliu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Retain the selected private offer through failed lookup/refresh, and record the verified staging deployment without claiming completed signed-in race acceptance. Related to open #731; this follow-up does not close it.
Officer impact: Clearly distinguish deployed code/anonymous page from unavailable supervised signed-in signup/refund-credit/transfer tests. No real club policy, payments or production release.
Officer documentation:
STAGING_COMMUNITY.md, entrypoints,EVENTS_SHOP_MEMBERS.md,SYSTEM_MAPS.mdand relevant root checkpoint. Older source-only/not-deployed notes are explicitly historical. Dave remains sole approver; fixtures/security/cleanup/rollback remain specialist-only, no officer terminal or secret sharing.Deployment evidence: PR734/merge669e2fb, exact PR38455181292/main38455775086 six jobs/every step success. Fixed Function release and independent read-only verifier exit0; v6 downloaded101,386-byte94380430 archive, exact settings/owner/MFA/unchanged profiles and six-permission/zero-key limits. Backend before dependent Hosting; public marker, actual HTML and main JS match. Actual anonymous390×844 screen has no overflow/controls. Two unauthenticated/unattested native denials do not isolate attestation or prove signed-in coverage. Native receipt: #731 (comment)
Handoff review found one UI recovery defect: after selecting offer B and its read failing, Refresh requested prior offer A. The new focused regression failed before the fix. Save the caller-selected focus before its read, while retaining fail-closed controls/context fencing and explicit own-only recovery. No mutation or extra read is added. Final focused race checks/type/lint must pass; exact all-six PR/main checks are still required. The previous docs-only green head is NOT acceptance for this subsequent correction.
Final local result:79 focused race tests, TypeScript, exact lint baseline and whitespace pass; regression assertion is unchanged and now passes. No added lint debt. System-map read now names the selected ID. Source/self-review confirms generation/session fences and acceptance's null-focus own-read still apply.
No Functions/runtime/archive/rules/package/workflow/provider/data change. The backend bundle remains identical to deployed94380430; no repeat paid Function build is needed. Corrected frontend Hosting must publish only after the exact merged source passes checks, and remains distinct from still-pending genuine signed-in acceptance. Earlier669e2fb deployment proof is dated historical proof, not publication of this UI fix.
Remaining: genuine disposable signed-in Auth/App Check/caller/grant/private status and all fictional actions, failure/exact retry/expiry/revocation/recipient-loss/mobile, fenced owned cleanup/late absence and qualified no-terminal handoff. No hosted fixture/account/record/receiver/grant was created in this release slice. Viewport restored and synthetic diagnostic output cleaned; source/current/rollback proof retained. Temporary receiver approval is requested, not assumed. Production and real payments untouched; full goal active.