Repository navigation
Require current membership for free-event signup - #738
Conversation
✅ Deploy Preview for luminous-fox-7c393f ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Owner-delegated Opus code approval — October 16, 2026Dave instructed: “Approval should come automatically if Opus 5.5 medium/max approve on a code review.” Independent native Claude CLI2.1.280 review ran exact model claude-opus-5-5, max effort, with only Read/Grep/Glob in safe/restricted mode and no fallback, hooks/plugins/MCP, shell or edit tools. Native init and final model usage confirm the exact model; final verdict is APPROVE for head e616b37, base d90cb22. It found no correctness or security regression. The reviewer inspected the actual transaction, authority reducer, callable identity boundary, UI, unit/emulator fixtures, Rules, CI and draft/officer material. It confirmed current membership and capacity share a transaction, time is sampled after reads, denials precede writes, saved success is read-only, cancellation remains available after expiry and drafts remain unused. Non-blocking evidence limitation: the suspension race test allows either valid serializable outcome, so that test alone does not detect moving membership outside the transaction. Actual code inspection establishes the current same-transaction read. The reviewer had no shell for hashes and its CI projection lacked the head SHA; the orchestrator independently rehashed every changed file and freshly verified run38767846712 binds this exact head, all six jobs and every step success, latest exact-head CI, unchanged PR/main base and a clean source tree. Code approval is accepted under Dave's delegation. GitHub still requires another account's review and cannot accept author self-approval; the acting owner will use the existing administrator merge capability for this exact passing head and record it as an owner-authorized review-gate override, not a fabricated GitHub APPROVED review. No branch protection is edited and no new reviewer identity is created. Officer impact: current-member admission source accepted; membership/event production remains unavailable. Officer documentation: PR738 source procedure/maps and draft packet remain unchanged. Deployment evidence: code review and exact-head CI only; no new Firebase/Hosting/provider/production deployment or payment. Final privacy/retention/waiver/guardian policy, protected release and provider/live-payment gates remain separate. #731 sealed evidence/fixtures remain untouched. |
Outcome
A verified account without current membership can currently take a free-event place. Require canonical current membership inside the same transaction as capacity, while preserving cancellation after expiry/suspension and read-only replay of saved success.
Scope
Officer handoff
Officer impact: Only current members can create new free-event signups after the later release; former members can still cancel. No extra discretionary member approval is added.
Officer documentation: OFFICER_START_HERE.md; docs/officers/README.md, EVENTS_SHOP_MEMBERS.md, STAGING_COMMUNITY.md, SYSTEM_MAPS.md; docs/MEMBER_LAUNCH_SCOPE.md; docs/legal/MEMBER_LAUNCH_DRAFTS.md; matching root architecture/security/operations/status notes.
Approving role: Dave for source/release; club privacy/legal/insurance owner for final policy/guardian wording. Standing build/deploy approval is retained; policy approval is not inferred from it.
Preview: deterministic member-screen tests; no real account or screenshot. Undo: hold publication or use a compatible reviewed correction/rollback; never edit a member or booking directly.
Deployment evidence: No new Function/Hosting/production/provider deployment. Existing #731 accepted staging receipt stays closed and its fixtures/harness are untouched. Exact current deployment remains dated prior evidence, not reverified by this source change.
Validation
Proof by surface
Source changed and local checks passed. Code merged: not yet. Website published/runmprc.com/Firebase deployed/provider configured/production behavior: not changed or qualified by this PR. Exact-head source/emulator CI38767846712 is complete and green; the Netlify synthetic preview also passed. No provider acceptance or production behavior is inferred.
Safety review