feat: Board task DAG + Agent Profiles (dispatcher on Cue tick, worktree isolation, plugin-bus events, CLI parity)

[chr1syy]

Board and Agent Profiles

Adds the Board: a persistent, git-trackable task DAG in .maestro/board.yaml whose cards are dispatched to Agent Profiles on the existing Maestro Cue engine tick (no second timer). Encore-gated, and gated again on Cue.

Core

• Agent Profiles (.maestro/profiles.yaml): named model / effort / role-prompt / args override bundles, resolved as profile, then base agent, then unset onto the existing spawn options. No new spawn parameters.
• Board dispatcher: promote (all parents done), then claim up to a WIP cap, then spawn, then apply. The board is persisted before any spawn resolves, so a restart or a re-entrant tick can never double-dispatch. Retries are bounded by a circuit breaker; every attempt is recorded as an auditable CardRun.
• Worker pool (opt-in): an agent with boardWorker: true whose working dir is inside the project can pick up role-only cards. Interactive agents are never hijacked.
• Per-card git worktrees: a card can run in its own checkout on board/<board>/<card>, so cards dispatched in the same tick cannot collide. Provisioning goes through the single shared setupWorktreeLocal; nothing is auto-merged or auto-deleted. SSH remotes are refused rather than silently downgraded to a local checkout.
• Full CLI parity (maestro-cli board / profile): board and card lifecycle, profile lifecycle, tick, and watch, all through the same storage modules and the same spawn path as the desktop app, so SSH remotes and profile overrides behave identically.
• Plugin bus: four metadata-only topics (board.cardStatusChanged, board.cardCompleted, board.cardBlocked, board.decomposed) at host API 1.15.0, on top of rc's 1.14.0 (tool.executed + ui.panelPost). Titles ship; summaries, prompts, outputs, and block reasons never do. The vendored plugin-sdk contracts are bumped in lockstep (0.10.0) with the drift guard green.
• Optional auto-decompose, off by default: one LLM pass fans a triage card into a wired child graph, capped per tick, using the editable board-decompose core prompt.

Safety

Board and profile YAML loads fail closed (an unreadable file blocks writes instead of being silently replaced by an empty board, which used to destroy data), writes are atomic temp-file+rename, and async read-modify-write callers serialize through a shared per-file write chain. Card deletion keeps the DAG referentially intact through grandparent adoption. Deleting a board with unfinished cards requires an explicit force.

UI

Kanban modal with keyboard parity (a "Move to" picker rather than ARIA drag-and-drop), multi-board switching, per-card stop, done/blocked toasts, an expandable last-run summary, and a running/ready pill in the Main Window header. Both the modal and the pill update from a board:changed push after every write; nothing polls.

Docs: docs/board.md (users), docs/agent-guides/BOARD.md (contributors), docs/cli-reference.md (flags).

Tests: shared DAG/markers/pool/types, storage, dispatcher, spawn, worktree, decompose, both CLI command suites, BoardModal, ProfilesModal, extension model, plugin events, and the SDK drift guard.

Known gaps (documented, deliberate):

• The pool busy-set is per board, not per project: two boards in one project can hand the same agent a card concurrently. Fixing it needs a project-wide busy set; called out in both guides.
• A tier-2 plugin cannot yet hold agents:dispatch / process:spawn for the Board; the runtime dispatch-grant seam is specified in Plans/rfc-runtime-dispatch-grants.md and dispatch stays host-owned until it exists.
• No live output streaming for card runs; you get the exit status, completion marker, and optional summary.

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features

  • Introduced the Board experience with persistent task DAGs: dispatcher ticks, WIP-limited claiming, card status transitions, optional triage auto-decomposition, and per-card isolated worktrees.
  • Added Agent Profiles with a dedicated desktop modal, role-based board worker opt-in, and full maestro-cli board / maestro-cli profile headless management (including board tick/watch).

• Documentation

  • Added/expanded Board and Agent Profiles guides plus CLI reference and Host API event documentation; updated navigation to include the Board feature.

• Plugin Updates

  • Bumped Host API to 1.15.0 and added metadata-only board event topics for card lifecycle updates and decomposition.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

📝 Walkthrough

Walkthrough

The PR adds persistent Board and Agent Profiles, including storage, dispatching, worktree isolation, CLI and renderer interfaces, plugin contracts, host API 1.15.0 updates, documentation, and automated coverage.

Changes

Board and Agent Profiles

Layer / File(s)	Summary
Shared contracts and persistence src/shared/board/*, src/shared/profiles/*, src/main/board/*, src/main/profiles/*	Defines Board, card, graph, worktree, pool, marker, and Agent Profile contracts, validation, atomic YAML persistence, dispatcher transitions, cancellation, worker assignment, and auto-decomposition.
Runtime, CLI, and IPC integration src/main/cue/*, src/main/index.ts, src/cli/*, src/main/ipc/*, src/main/preload/*	Runs Board dispatch from Cue heartbeats, wires cancellation and notifications, adds Board/Profile CLI commands, and exposes IPC and preload APIs.
Renderer features src/renderer/components/*, src/renderer/App.tsx, src/renderer/stores/*, src/renderer/global.d.ts	Adds Board and Profiles modals, activity status, feature dependency gating, quick actions, keyboard controls, live refresh, and Board worker opt-in.
Plugin contracts and host API src/shared/plugins/*, packages/plugin-sdk/*	Registers the Board first-party plugin, adds four metadata-only Board event topics, and updates host API and SDK versions.
Documentation and validation docs/*, Plans/*, src/prompts/*, src/__tests__/*	Documents Board, Profiles, CLI, plugin events, runtime dispatch planning, and validates storage, dispatch, worktrees, CLI behavior, and renderer interactions.

Estimated code review effort: 5 (Critical) | ~120 minutes

Possibly related PRs

• RunMaestro/Maestro#571: Shares the renderer modal wiring surface.
• RunMaestro/Maestro#789: Shares contributor guidance changes in CLAUDE.md.
• RunMaestro/Maestro#1254: Shares plugin event and host API contract surfaces.

Suggested reviewers: pedramamini, stevenmgordon

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 77.70% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main changes: Board task DAGs and Agent Profiles with dispatcher, worktree, events, and CLI support.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[greptile-apps]

Greptile Summary

This PR adds persistent Board workflows and reusable Agent Profiles. The main changes are:

• Cue-driven DAG promotion, dispatch, retry, cancellation, and completion handling.
• Worker-pool assignment and per-card Git worktree isolation.
• Shared YAML storage with atomic writes and fail-closed loading.
• Desktop, CLI, preload, IPC, and modal support for boards and profiles.
• Metadata-only Board events for the plugin bus.

Confidence Score: 4/5

CLI Board execution can lose persisted transitions, exclude valid workers, and bypass requested worktree isolation.

• Concurrent CLI and desktop writes can replace newer Board state with a stale snapshot.
• CLI pool discovery omits directory fallbacks used by the desktop dispatcher.
• Auto-decomposition always runs in the shared checkout.
• The core dispatcher includes strong persist-before-spawn and cancellation safeguards.

src/cli/commands/board.ts and the cross-process Board storage boundary

Important Files Changed

Filename	Overview
src/cli/commands/board.ts	Adds full Board CLI support, but concurrent finalization can lose state, pool discovery diverges from desktop behavior, and decomposition ignores worktree isolation.
src/main/board/board-dispatcher.ts	Adds promotion, claiming, retries, stale-run reclamation, cancellation tombstones, and result application.
src/main/board/board-storage.ts	Adds fail-closed YAML loading, DAG validation, atomic replacement, mutations, and process-local write serialization.
src/main/board/board-spawn.ts	Adds profile resolution, worker assignment, Cue execution, cancellation tracking, SSH handling, and worktree-aware card execution.
src/main/board/board-worktree.ts	Adds per-card worktree provisioning through the shared Git worktree helper.
src/main/cue/cue-engine.ts	Integrates Board dispatch and decomposition with the existing Cue heartbeat.

Sequence Diagram

sequenceDiagram
    participant CLI as CLI board tick
    participant Disk as board.yaml
    participant Desktop as Desktop dispatcher
    CLI->>Disk: Load snapshot A
    Desktop->>Disk: Load current board
    Desktop->>Disk: Persist transition B
    CLI->>CLI: Apply result to snapshot A
    CLI->>Disk: Replace file with snapshot A
    Note over Disk: Transition B is lost

Loading

_{Reviews (1): Last reviewed commit: "MAESTRO: fix stale host-API version in p..." | Re-trigger Greptile}

[coderabbitai]

Actionable comments posted: 14

🧹 Nitpick comments (3)

src/renderer/components/ProfilesModal/ProfilesModal.tsx (1)

142-153: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win

Consider confirming profile deletion (and flagging in-use profiles).

handleDelete removes a profile immediately with no confirmation. Board cards that reference it via assigneeProfileId are then orphaned (they fall back to rendering the raw id and can no longer resolve the role at dispatch). This is inconsistent with the destructive-action guards elsewhere in this PR (board deletion confirm dialog, the tile's arm-then-delete). A confirm step, or at least a warning when the profile is still assigned to cards, would prevent silent breakage.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/renderer/components/ProfilesModal/ProfilesModal.tsx` around lines 142 -
153, Update handleDelete in ProfilesModal to require confirmation before
deleting a profile, and warn or block when the profile is referenced by board
cards through assigneeProfileId. Reuse the existing destructive-action
confirmation and profile/card data sources where available, preserving the
current delete, error logging, exception capture, and toast behavior after
confirmation.

src/renderer/components/Settings/Extensions/extensionModel.ts (1)

82-106: 🗄️ Data Integrity & Integration | 🔵 Trivial | 🏗️ Heavy lift

Share the dependency rule across renderer and main.

This mapping is explicitly a renderer-side mirror of the main-process gate. Keeping separate definitions can let a future dependency be enabled in one layer but rejected in the other. Move the mapping to a shared module imported by both layers, or add a parity test that exercises both paths.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/renderer/components/Settings/Extensions/extensionModel.ts` around lines
82 - 106, Centralize BUILTIN_DEPENDENCIES in a shared module consumed by both
the renderer dependency check isDependencyMet and the main-process dispatcher
gate. Remove the duplicate layer-specific mapping and update both consumers to
use the shared definition, preserving the existing board-to-maestroCue
dependency behavior.

src/cli/commands/board.ts (1)

1005-1013: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win

Pass customArgs through to spawnAgent() in the decompose spawn.

This CLI spawn site forwards customModel, customEffort, customEnvVars, and sshRemoteConfig but drops customArgs, so a role's extra CLI args are silently lost on the auto-decompose pass (the sibling spawnCard does pass it). overrides here can carry customArgs from resolveCliAssignment.

As per coding guidelines: "For new CLI agent spawn sites, pass sessionSshRemoteConfig, customArgs, customEnvVars, customModel, and customEffort through to spawnAgent()".

♻️ Proposed fix

 		const result = await spawnAgent(base.toolType as ToolType, projectRoot, prompt, undefined, {
 			customModel: overrides?.customModel,
 			customEffort: overrides?.customEffort,
+			customArgs: overrides?.customArgs,
 			customEnvVars: base.customEnvVars,
 			sshRemoteConfig: base.sessionSshRemoteConfig,
 			enableMaestroP: base.enableMaestroP,
 			maestroPMode: base.maestroPMode,
 			maestroPPath: base.maestroPPath,
 		});

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/cli/commands/board.ts` around lines 1005 - 1013, Update the decompose
spawn call to spawnAgent in the surrounding command flow to forward
overrides?.customArgs alongside the existing customModel and customEffort
options, preserving the resolved role-specific CLI arguments during
auto-decompose.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/agent-guides/BOARD.md`:
- Line 177: Update the wording in the profile editing guidance to use “drivable”
instead of “driveable”, without changing the surrounding behavior or technical
details.
- Line 180: The cross-process dispatcher documentation incorrectly describes
desktop and CLI overlap as safe; update the guidance to warn that concurrent
read-modify-write cycles can overwrite persisted card transitions. In
docs/agent-guides/BOARD.md line 180, replace “safe” with the explicit
lost-update warning; in docs/board.md line 215, make overwrite risk the primary
behavior rather than a secondary caveat; and in docs/cli-reference.md line 613,
describe overlap as unsupported.

In `@docs/board.md`:
- Line 207: Update the board tick documentation to define completion as all
cards reaching terminal states, specifically done or blocked, rather than
stopping when nothing remains to promote. Revise the repeated-tick guidance in
the board workflow example to continue while cards are running, ready, or
awaiting retry, and mention a status check only if an existing documented
command supports automation.

In `@docs/cli-reference.md`:
- Around line 591-599: Update the set-status documentation to list only the
accepted manual transitions: triage, todo, blocked, and done; remove ready and
running from the status values, and do not imply that users can set
dispatcher-managed states through this command.

In `@Plans/rfc-runtime-dispatch-grants.md`:
- Around line 77-80: Clarify the project-root grant definition to require
canonical path resolution for both the configured project root and candidate
paths, separator-aware containment that excludes similarly prefixed paths such
as “repo-evil,” and explicit symlink and traversal handling that prevents
escaping the canonical project-root boundary.

In `@src/__tests__/renderer/components/BoardModal.test.tsx`:
- Around line 489-509: Widen the elapsed-time assertion in the “shows attempt,
elapsed time and the pooled worker on a running tile” test to match any seconds
value within the minute, rather than only single-digit seconds. Keep the
assertion anchored to the existing formatted “1m …s” output so it remains
tolerant of slow rendering.

In `@src/main/utils/atomic-json-store.ts`:
- Around line 116-129: Update atomicWriteFileSync to retry renameSync on
transient EPERM or EBUSY errors using the same bounded retry limit and
synchronous backoff as atomicWriteFile. Preserve cleanup of the temporary file
and rethrow non-retryable or ultimately failed errors.

In `@src/prompts/board-decompose.md`:
- Around line 12-18: Update the child-card count instruction in the
decomposition prompt so the two-to-six requirement applies normally, while
explicitly allowing a single child card when the source card is atomic. Preserve
the existing guidance for actionable scope, dependency ordering, imperative
titles, and avoiding invented work.

In `@src/renderer/components/AppStandaloneModals.tsx`:
- Around line 427-432: The Board modal must remain unavailable unless Maestro
Cue is enabled. In src/renderer/components/AppStandaloneModals.tsx lines
427-432, update the BoardModal render condition to also require
encoreFeatures.maestroCue; in
src/renderer/components/Settings/Extensions/ExtensionDetails.tsx lines 603-624,
update the active Open Board action to require dependencyMet and otherwise
display the existing dependency hint.

In `@src/renderer/components/BoardStatusIndicator.tsx`:
- Around line 47-51: Update the catch block in BoardStatusIndicator’s
card-counting flow to distinguish known recoverable board-list errors from
unexpected IPC failures. Keep the zero-count fallback and warning for recognized
recoverable errors, but report unexpected exceptions through the project’s
Sentry exception-reporting utility or rethrow them instead of silently
converting them to zero counts.
- Around line 39-53: The refresh callback in BoardStatusIndicator must prevent
an outdated board.list result from updating counts after projectRoot changes.
Add a request-generation or cancellation guard around the asynchronous work in
refresh, and only commit setCounts results or fallback values for the currently
active request; invalidate the prior request when dependencies change or the
callback is superseded.

In `@src/renderer/hooks/session/useSessionLifecycle.ts`:
- Around line 213-215: Update the agent-save payload containing boardWorker so
it only applies that field when the optional boardWorker argument is defined,
preserving an existing true opt-in when callers omit it. Keep the current value
unchanged for undefined arguments while retaining explicit true or false values.

In `@src/shared/board/worktree.ts`:
- Around line 35-60: Update boardCardBranchName to avoid truncating boardId and
cardId to only ID_SEGMENT_LENGTH characters. Use full validated IDs or append
collision-resistant suffixes derived from the complete IDs, while preserving
sanitization, fallback values, and the existing branch/path construction used by
boardWorktreePath and buildCardWorktreeRef.

In `@src/shared/profiles/types.ts`:
- Around line 109-137: Update validateAgentProfile so every present optional
field (baseAgentId, model, effort, appendSystemPrompt, and customArgs) causes
the whole profile to return null when its value is not a string. Refactor
optionalString or its callers to distinguish absent fields from malformed
values, while preserving normalization of blank strings to absent and trimming
retained values consistently.

---

Nitpick comments:
In `@src/cli/commands/board.ts`:
- Around line 1005-1013: Update the decompose spawn call to spawnAgent in the
surrounding command flow to forward overrides?.customArgs alongside the existing
customModel and customEffort options, preserving the resolved role-specific CLI
arguments during auto-decompose.

In `@src/renderer/components/ProfilesModal/ProfilesModal.tsx`:
- Around line 142-153: Update handleDelete in ProfilesModal to require
confirmation before deleting a profile, and warn or block when the profile is
referenced by board cards through assigneeProfileId. Reuse the existing
destructive-action confirmation and profile/card data sources where available,
preserving the current delete, error logging, exception capture, and toast
behavior after confirmation.

In `@src/renderer/components/Settings/Extensions/extensionModel.ts`:
- Around line 82-106: Centralize BUILTIN_DEPENDENCIES in a shared module
consumed by both the renderer dependency check isDependencyMet and the
main-process dispatcher gate. Remove the duplicate layer-specific mapping and
update both consumers to use the shared definition, preserving the existing
board-to-maestroCue dependency behavior.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f7782068-4d68-4210-a0e7-1c741dabb069

📥 Commits

Reviewing files that changed from the base of the PR and between cb7fcf8 and 3c4ef0b.

⛔ Files ignored due to path filters (1)

• package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (92)

• CLAUDE-PLUGINS.md
• CLAUDE.md
• Plans/board-10x-summary.md
• Plans/rfc-runtime-dispatch-grants.md
• docs/agent-guides/BOARD.md
• docs/agent-guides/PLUGIN-DEVELOPMENT.md
• docs/board.md
• docs/cli-reference.md
• docs/docs.json
• packages/plugin-sdk/package.json
• packages/plugin-sdk/src/__tests__/drift.test.ts
• packages/plugin-sdk/src/index.ts
• src/__tests__/cli/commands/board.test.ts
• src/__tests__/cli/commands/profile.test.ts
• src/__tests__/main/board/board-decompose.test.ts
• src/__tests__/main/board/board-dispatcher.test.ts
• src/__tests__/main/board/board-spawn.test.ts
• src/__tests__/main/board/board-worktree.test.ts
• src/__tests__/main/board/storage.test.ts
• src/__tests__/main/profiles/storage.test.ts
• src/__tests__/renderer/components/BoardModal.test.tsx
• src/__tests__/renderer/components/MainPanel/MainPanelHeader.test.tsx
• src/__tests__/renderer/components/NewInstanceModal/EditAgentModal.test.tsx
• src/__tests__/renderer/components/ProfilesModal.test.tsx
• src/__tests__/renderer/components/QuickActionsModal/commands/commandBuilders.test.ts
• src/__tests__/renderer/components/Settings/Extensions/extensionModel.test.ts
• src/__tests__/shared/board/cardMarkers.test.ts
• src/__tests__/shared/board/graph.test.ts
• src/__tests__/shared/board/pool.test.ts
• src/__tests__/shared/board/types.test.ts
• src/__tests__/shared/pianola/pianola-first-party-plugin.test.ts
• src/__tests__/shared/plugins/board-first-party.test.ts
• src/__tests__/shared/plugins/events.test.ts
• src/__tests__/shared/profiles/types.test.ts
• src/cli/commands/board.ts
• src/cli/commands/profile.ts
• src/cli/index.ts
• src/main/board/board-decompose.ts
• src/main/board/board-dispatcher.ts
• src/main/board/board-spawn.ts
• src/main/board/board-storage.ts
• src/main/board/board-worktree.ts
• src/main/cue/cue-engine.ts
• src/main/cue/cue-yaml-write.ts
• src/main/index.ts
• src/main/ipc/handlers/board.ts
• src/main/ipc/handlers/git.ts
• src/main/ipc/handlers/index.ts
• src/main/ipc/handlers/profiles.ts
• src/main/preload/board.ts
• src/main/preload/index.ts
• src/main/preload/profiles.ts
• src/main/profiles/profile-storage.ts
• src/main/utils/atomic-json-store.ts
• src/main/utils/git-worktree.ts
• src/prompts/board-decompose.md
• src/renderer/App.tsx
• src/renderer/components/AppModals/AppModals.tsx
• src/renderer/components/AppModals/AppSessionModals.tsx
• src/renderer/components/AppModals/AppUtilityModals.tsx
• src/renderer/components/AppStandaloneModals.tsx
• src/renderer/components/BoardModal.tsx
• src/renderer/components/BoardStatusIndicator.tsx
• src/renderer/components/MainPanel/MainPanelHeader.tsx
• src/renderer/components/NewInstanceModal/EditAgentModal.tsx
• src/renderer/components/NewInstanceModal/types.ts
• src/renderer/components/ProfilesModal/ProfilesModal.tsx
• src/renderer/components/QuickActionsModal/QuickActionsModal.tsx
• src/renderer/components/QuickActionsModal/commands/featureCommands.ts
• src/renderer/components/QuickActionsModal/types.ts
• src/renderer/components/Settings/Extensions/ExtensionDetails.tsx
• src/renderer/components/Settings/Extensions/ExtensionsGrid.tsx
• src/renderer/components/Settings/Extensions/ExtensionsView.tsx
• src/renderer/components/Settings/Extensions/extensionModel.ts
• src/renderer/constants/modalPriorities.ts
• src/renderer/global.d.ts
• src/renderer/hooks/session/useSessionLifecycle.ts
• src/renderer/stores/modalStore.ts
• src/renderer/stores/settingsStore.ts
• src/renderer/types/index.ts
• src/shared/board/cardMarkers.ts
• src/shared/board/graph.ts
• src/shared/board/pool.ts
• src/shared/board/types.ts
• src/shared/board/worktree.ts
• src/shared/maestro-paths.ts
• src/shared/plugins/events.ts
• src/shared/plugins/first-party.ts
• src/shared/plugins/host-api.ts
• src/shared/profiles/types.ts
• src/shared/promptDefinitions.ts
• src/shared/types.ts

[coderabbitai]

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (2)

src/main/index.ts (2)

1599-1604: 🔒 Security & Privacy | 🟠 Major | ⚡ Quick win

Keep agent output out of plugin events.

The blocked-card event spreads event.outcome into a contract described as metadata-only, even though outcomes may contain agent summaries or output. Remove it or emit only explicitly allow-listed metadata.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/main/index.ts` around lines 1599 - 1604, Update the blocked-card event
emission in the blocked branch to stop spreading event.outcome into payload;
preserve only the common metadata, or include solely explicitly allow-listed
metadata fields that comply with the event contract.

---

1565-1568: 🗄️ Data Integrity & Integration | 🟠 Major | 🏗️ Heavy lift

Serialize all Board read-modify-write operations.

Cue dispatch and auto-decomposition bypass the queue used by Board IPC mutations, allowing stale snapshots to overwrite concurrent edits.

• src/main/index.ts#L1565-L1568: serialize dispatcher reads and saves through the per-project Board queue.
• src/main/index.ts#L1659-L1662: serialize decomposition reload, merge, and save through the same queue.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/main/index.ts` around lines 1565 - 1568, Serialize both Board
read-modify-write flows through the per-project Board queue: in
src/main/index.ts lines 1565-1568, update the dispatcher’s listBoards/saveBoard
operations; in src/main/index.ts lines 1659-1662, update decomposition reload,
merge, and save operations. Ensure each flow reads the current board and
persists its changes within the same queue serialization used by Board IPC
mutations.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@node_modules`:
- Line 1: Remove the host-specific node_modules symbolic link from version
control and add node_modules/ to the repository’s ignore configuration. Do not
replace it with another link unless the project explicitly requires a
repository-relative target.

---

Outside diff comments:
In `@src/main/index.ts`:
- Around line 1599-1604: Update the blocked-card event emission in the blocked
branch to stop spreading event.outcome into payload; preserve only the common
metadata, or include solely explicitly allow-listed metadata fields that comply
with the event contract.
- Around line 1565-1568: Serialize both Board read-modify-write flows through
the per-project Board queue: in src/main/index.ts lines 1565-1568, update the
dispatcher’s listBoards/saveBoard operations; in src/main/index.ts lines
1659-1662, update decomposition reload, merge, and save operations. Ensure each
flow reads the current board and persists its changes within the same queue
serialization used by Board IPC mutations.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 31144c2d-2871-4d95-a8ab-a01ecf2c0c60

📥 Commits

Reviewing files that changed from the base of the PR and between 63f239e and 4d7b58c.

📒 Files selected for processing (18)

• CLAUDE.md
• docs/agent-guides/PLUGIN-DEVELOPMENT.md
• node_modules
• packages/plugin-sdk/src/__tests__/drift.test.ts
• packages/plugin-sdk/src/index.ts
• src/__tests__/renderer/components/Settings/Extensions/extensionModel.test.ts
• src/__tests__/renderer/hooks/useSessionLifecycle.test.ts
• src/main/cue/cue-engine.ts
• src/main/index.ts
• src/renderer/App.tsx
• src/renderer/components/Settings/Extensions/ExtensionsView.tsx
• src/renderer/components/Settings/Extensions/extensionModel.ts
• src/renderer/global.d.ts
• src/renderer/hooks/session/useSessionLifecycle.ts
• src/renderer/hooks/session/useSessionSwitchCallbacks.ts
• src/renderer/stores/settingsStore.ts
• src/renderer/types/index.ts
• src/shared/types.ts

🚧 Files skipped from review as they are similar to previous changes (12)

• packages/plugin-sdk/src/tests/drift.test.ts
• src/renderer/stores/settingsStore.ts
• src/renderer/types/index.ts
• CLAUDE.md
• src/renderer/components/Settings/Extensions/ExtensionsView.tsx
• docs/agent-guides/PLUGIN-DEVELOPMENT.md
• src/renderer/hooks/session/useSessionLifecycle.ts
• src/shared/types.ts
• packages/plugin-sdk/src/index.ts
• src/renderer/global.d.ts
• src/renderer/App.tsx
• src/main/cue/cue-engine.ts

[pedramamini]

@chr1syy first off, thank you for this - it is a genuinely impressive contribution. The Board DAG plus Agent Profiles is a large, coherent feature, and the care shows: the decision records at the top of board-spawn.ts, the fail-closed YAML loading, persisting the board before any spawn resolves, refusing SSH remotes on worktree cards instead of silently downgrading to a local checkout, and the explicitly documented known gaps in the description. That is the kind of write-up that makes a 100-file PR reviewable at all.

I have gone through both AI reviews and the code. Status from my side:

• Greptile and CodeRabbit: every inline thread is resolved, and your responses on the three P1s are the right calls (the CLI pool s.projectRoot || s.cwd fix, documenting the process-local write chain rather than bolting on a partial lock, and the decompose-in-projectRoot parity with the desktop path).
• CI: all six checks green, including both the ubuntu and windows legs.
• Gating: verified on both sides. AppStandaloneModals requires encoreFeatures.board && encoreFeatures.maestroCue, and CueEngineBoardDeps.getEncoreFeatures re-reads both flags each tick, so toggling either at runtime takes effect immediately. Good.

Two CodeRabbit findings landed as "outside diff range" notes, so they never became threads and could look unaddressed. For the record, I checked both and neither blocks:

1. "Keep agent output out of plugin events" on the board.cardBlocked payload. This is a false positive. event.outcome is CardRunOutcome, a closed string union, not free text or agent output, so the metadata-only contract holds.
2. "Serialize all Board read-modify-write operations". This is the same cross-process lost-update issue Greptile raised, and you have already documented it as a deliberate one-dispatcher-per-board rule in docs/board.md and BOARD.md. Fine as a documented gap.

The one thing blocking merge: conflicts

The branch is 129 commits behind rc (merge base 2bf0d698e, last branch commit Aug 11), and it no longer merges cleanly. Could you please merge or rebase onto current rc and resolve? Nine files conflict:

src/main/ipc/handlers/git/worktree.ts
src/renderer/hooks/session/useSessionLifecycle.ts
src/renderer/components/NewInstanceModal/EditAgentModal.tsx
src/renderer/components/NewInstanceModal/types.ts
src/renderer/components/AppModals/AppSessionModals.tsx
src/renderer/stores/modalStore.ts
src/shared/promptDefinitions.ts
src/__tests__/renderer/hooks/useSessionLifecycle.test.ts
src/__tests__/renderer/components/NewInstanceModal/EditAgentModal.test.tsx

Two of these need more than a mechanical resolution, so flagging them specifically:

• src/main/ipc/handlers/git/worktree.ts is the risky one. Your PR lifts the local git worktree add path out of the IPC handler into utils/git-worktree.ts (setupWorktreeLocal), while rc has since changed the code still inlined in the handler. Taking your side wholesale would silently drop those rc changes. Please port them into the extracted setupWorktreeLocal so the Board and the handler stay on one implementation, which was the whole point of the extraction.
• useSessionLifecycle.ts / EditAgentModal.tsx / types.ts now sit on top of Provider Failover (feat(resilience): Provider Failover to Anthropic-compatible backup endpoints #1334) and the provider-preserving tabs work in rc. Your boardWorker opt-in threading through the agent edit flow will need to be re-fitted against the reshaped agent config surface rather than replayed as-is.

Once it merges cleanly and both CI legs are green again, ping me and I will take another pass. Nothing in the code itself is holding this up.