gccrs: Handle more llvm_asm usages - #4786
Merged
Merged
Conversation
powerboat9
marked this pull request as draft
August 16, 2026 16:52
More subtle differences between GCC and LLVM inline assembly might be an issue in the future, but this should handle or safely reject most usages. gcc/rust/ChangeLog: * ast/rust-expr.h (LlvmInlineAsm::LlvmInlineAsm): Initialize more member variables. (LlvmInlineAsm::get_dialect): Make function const qualified. (LlvmInlineAsm::is_stack_aligned): Likewise. (LlvmInlineAsm::is_volatile): Likewise. * backend/rust-compile-asm.cc (CompileLlvmAsm::construct_operands): Handle llvm-specific "=*m" constraint. (CompileLlvmAsm::tree_codegen_asm): Handle change from multiple template strings to a single template string. * hir/rust-ast-lower-expr.cc (convert_template_str): New function. (check_llvm_asm_support): Remove unnecessary parameters and expand the set of allowed llvm_asm usages. (ASTLoweringExpr::visit (LlvmInlineAsm)): Adjust lowering. * hir/tree/rust-hir-expr.h (LlvmInlineAsm::templates): Remove member variable and replace with... (LlvmInlineAsm::template_str): ...new member variable. (LlvmInlineAsm::LlvmInlineAsm): Handle member variable changes. (LlvmInlineAsm::get_templates): Remove member function and replace with... (LlvmInlineAsm::get_template): ...new member function. * hir/tree/rust-hir-visitor.cc (DefaultHIRVisitor::walk (LlvmInlineAsm)): Visit outer attributes. * typecheck/rust-hir-type-check-expr.cc (TypeCheckExpr::visit (LlvmInlineAsm)): Adjust comments. Signed-off-by: Owen Avery <powerboat9.gamer@gmail.com>
powerboat9
marked this pull request as ready for review
August 17, 2026 02:34
philberty
approved these changes
Aug 17, 2026
P-E-P
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More subtle differences between GCC and LLVM inline assembly might be an issue in the future, but this should handle or safely reject most usages.