Skip to content

[ryoku] fastfetch: preserve markers on save - #680

Merged
neur0map merged 1 commit into
Ryoku-dev:unstable-devfrom
Satirito:fix/fastfetch-renderer-marker
Oct 31, 2026
Merged

neur0map merged 1 commit into
Ryoku-dev:unstable-devfrom
Satirito:fix/fastfetch-renderer-marker

Conversation

@Satirito

@Satirito Satirito commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

What changed

Keep Fastfetch renderer and recolor markers when Settings saves a config. Renderer backed styles show their fixed rows without allowing edits that break the layout.

Area

ryoku

How it was tested

  • go build ./...
  • go vet ./...
  • go test ./...
  • qmllint on the changed QML files
  • Tested applying and previewing Filigree in Ryoku Hub, then running ryoku-fastfetch.

Checklist

  • One logical change with a [ryoku] commit subject.
  • ryoku/hub/CHANGELOG.md updated.
  • Build, vet, tests, and QML lint pass locally.
  • No duplicated config or dead code added.

@Satirito
Satirito changed the base branch from main to unstable-dev October 31, 2026 12:54
Note: Fixed: Fastfetch styles keep their renderer and theme roles after saving in Settings.
@Satirito
Satirito force-pushed the fix/fastfetch-renderer-marker branch from 36f059a to efb3305 Compare October 31, 2026 13:01
@Satirito Satirito changed the title [ryoku] fastfetch: preserve renderer and recolor on save [ryoku] fastfetch: preserve markers on save Oct 31, 2026
@Satirito

Copy link
Copy Markdown
Contributor Author

The Go unit test workflow is failing in two unrelated areas:

  • ryoku CLI: TestWatchdogNamesTheWorkInItsTree does not detect the child process (Pkg:false, empty Current).
  • shell IPC daemon: five nightlight tests time out waiting for an on:true frame.

I ran the same commands locally (go test ./... in ryoku/cli and go test -short ./... in ryoku/shell/ipc); both pass here. The failures are outside this PR’s changed files, and I have not established their root cause. Could someone with repository admin access review the failed job logs and advise whether to rerun the jobs or address a runner-specific test issue?

@neur0map
neur0map merged commit ce94af1 into Ryoku-dev:unstable-dev Oct 31, 2026
15 of 17 checks passed
@neur0map

Copy link
Copy Markdown
Member

Thanks for the work here, this ships in the next v1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants