Repository navigation
[ryoku] rashin: make Updates AI repair respond and support Codex - #732
Merged
Merged
Conversation
Fix with AI knew only Hermes, Oh My Pi and one other harness, so a machine with Codex installed never opened Codex. A fix setting in rashin.json now names the harness apart from the chat agent and, for Codex, the model and reasoning effort of that one session, passed as -m and -c model_reasoning_effort so Codex's own config stays untouched. Note: New: Fix with AI can open Codex, with the model and effort set under "fix" in rashin.json
The Updates page button ran the full health check (50 to 94 s, with a 90 s cap) before any terminal opened, and threw away the command's output, so a press showed nothing and a failure left no trace. Off a terminal the fix now opens the terminal at once and runs the check there, held open on an error, and the button shows OPENING, then the command's answer or its error. Note: Fixed: Fix with AI on the Updates page now reacts at once and shows why when it cannot open
Use a shell so a missing Rashin executable returns a collected error. Clear the previous repair response when dismissing an update. Note: Fixed: Fix with AI shows missing-command errors and clears old feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Fix with AI on the Updates completion screen could appear unresponsive for 50 to 94 seconds while a health scan ran before the terminal opened. Launch failures disappeared because the page discarded the command output. Codex was also missing from the supported repair harnesses.
Open the terminal before scanning, show an immediate opening state, reject duplicate pending launches, and display the launch result or error. The terminal keeps scan errors visible. Rashin can now select Codex for repairs independently of its chat agent, with a model and reasoning effort for that session only. For example:
Existing harness preferences stay the same when
fixis unset. General Codex settings are unchanged.Area
ryoku, including the Settings Hub and Rashin.How it was tested
go test ./...andgo vet ./...passed. Regression tests cover the configured Codex arguments and opening a terminal before the health scan.codex execprobing confirmed the requested model and low effort work. No actual AI repair ran.The headless check invoked the button's action signal, not a pointer click. The user's live Hub button and native terminal window were not exercised. The scan timeout still applies inside the terminal. New UI strings await translation.
Isolated fixture captures, before and one second after activation:
Checklist
[area] scope: summarycommit subjects.--no-verify.