Repository navigation
[ryoku] lockscreen: keep the picked skin on the Fedora sign-in screen - #743
Merged
aethctl merged 1 commit intoNov 6, 2026
Merged
Conversation
sddm-theme-ryoku owned the skin files in /usr/share/sddm/themes/ryoku, the fixed directory the Hub's picker writes to, so every package update laid the shipped Orbital back over the shared host. The Hub kept naming the pick while the sign-in screen wore Orbital. The package now owns only the directory. ryoku-desktop's posttrans rebuilds the host around a skin already there, or seeds the default when there is none. Note: Fixed: your lock skin now stays on the Fedora sign-in screen after an update
itsKontra
force-pushed
the
fix/fedora-greeter-skin-overwrite
branch
from
November 5, 2026 21:14
dab13ec to
c302ec7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
On Fedora, a lock skin picked in the Hub does not stay on the sign-in screen.
sddm-theme-ryokuowned the skin files in/usr/share/sddm/themes/ryoku, the directory the picker writes to, so each package update put Orbital back. The Hub kept naming the pick. The Arch packaging has no owner for this path, so only Fedora is affected.Area
ryoku
How it was tested
Real
rpm -Uupgrades ofsddm-theme-ryoku, built from the old and new specs, in a throwaway RPM root. The new%posttransblock was extracted from the parsedryoku-desktopspec and run against that root:Main.qmltheme/theme/~/.config/qylock/themesaidlast-of-uswhile the greeter'sMain.qmlmatched the shipped Orbital byte for byte, and an earlier pick'sbg.mp4was still beside it.xdm_tto read thedata_home_tlabels thatcp -acarries over.Not tested:
ryoku-desktopRPM. Its spec was parsed, and the scriptlet passessh -n.Merge danger
Door: two-way. Reverting restores the old package payload. The only skin data involved is the copy under
/usr/share; the user's copy under~/.local/shareis never written.Blast radius: Fedora login screen.
ryoku-hub lock set <slug>.%posttransblock fails, the greeter directory has noMain.qmluntil a skin apply. The failure is logged underryoku-greeter. Doctor treats a missingMain.qmlas "not installed", so it will not repair this.Checklist
[area] scope: summarycommit subject.CHANGELOG.mdupdated in the area I touched.--no-verify.luac -p), shell scripts passbash -n, and QML passesqmllintwhere applicable. (No Lua or QML changed; the scriptlet passessh -n.)