Repository navigation
Conversation
Zed editor and other multi-theme templates define dual appearances
(Matugen Dark and Matugen Light) referencing {{colors.role.dark.hex}} and
{{colors.role.light.hex}}. Previously, parseMatugenPalette discarded the
dark and light buckets and matugenCarrier duplicated the active palette
across all three keys, causing both themes to render identically.
Extract active, dark, and light palettes from matugen JSON output and
populate the carrier with respective color maps while preserving backward
compatibility for {{colors.role.hex}} flat lookups.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Zed editor and other multi-theme templates define dual appearances (
Matugen DarkandMatugen Light) referencing{{colors.role.dark.hex}}and{{colors.role.light.hex}}. Previously,parseMatugenPalettediscarded thedarkandlightbuckets andmatugenCarrierduplicated the active palette across all three keys (default,dark,light). Consequently, both themes received identical colors, causing broken or inverted styling when wallpapers were light or using smart mode.This PR:
parseMatugenPaletteto extractactive,dark, andlightpalettes directly from matugen JSON buckets while preservingmodeKeypriority fallback for the active palette.matugenCarrierwith separate submaps fordefault,dark, andlight, while maintaining backward compatibility by flatteningdefaultentries directly on the role for templates using{{colors.role.hex}}.Area
ryoku
How it was tested
go test -v -run "TestMatugen" ./...inryoku/shell/ipc: all tests pass cleanly (TestMatugenIsolatedDrive,TestMatugenApply,TestMatugenApplyInvokesBinary,TestMatugenApplyNeutralizesAchromaticWallpaper).go build).darkandlightthemes.Checklist
[area] scope: summarycommit subject.CHANGELOG.mdupdated in the area I touched.--no-verify.luac -p), shell scripts passbash -n, and QML passesqmllintwhere applicable.