Skip to content

feat: |RPT] Update RPT client to version 1.5 - #976

Open
CharlesDuboisSAP wants to merge 12 commits into
mainfrom
rpt1.5
Open

feat: |RPT] Update RPT client to version 1.5#976
CharlesDuboisSAP wants to merge 12 commits into
mainfrom
rpt1.5

Conversation

@CharlesDuboisSAP

@CharlesDuboisSAP CharlesDuboisSAP commented Aug 7, 2026 •
edited by vladimir-a-sap
Loading

Copy link
Copy Markdown
Contributor

Context

Add RPT 1.5 support

Feature scope:

  • Generated new spec
  • Migrated spec-update.yaml to new spec
  • Fixed RptClient.tableCompletion, should be (File, String)
    • Improved Cloud SDK OpenAPI generator to take into account string and file types correctly, get inspired from JS
  • Added new tests for new explanation feature
  • Preserved existing RPT 1.0 alongside to the new RPT 1.5 for backwards compatibility / support

Definition of Done

  • Functionality scope stated & covered
  • Tests cover the scope above
  • Error handling created / updated & covered by the tests above
  • Aligned changes with the JavaScript SDK
  • Documentation updated
  • Release notes updated
    • Mini migration guide

@CharlesDuboisSAP CharlesDuboisSAP self-assigned this Aug 7, 2026
@ZhongpinWang

ZhongpinWang commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown

I see in the PR, the rpt 1.0 client is replaced by 1.5. I don't think it is possible to replace the support for the old model already by now or any time this year (according to the sap notes).

@CharlesDuboisSAP @Jonas-Isr

@vladimir-a-sap vladimir-a-sap changed the title feat: |RPT] Update specification to version 1.5 feat: |RPT] Support version 1.5 alongside the 1.0 Aug 18, 2026
@vladimir-a-sap

vladimir-a-sap commented Aug 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

I see in the PR, the rpt 1.0 client is replaced by 1.5. I don't think it is possible to replace the support for the old model already by now or any time this year (according to the sap notes).

@CharlesDuboisSAP @Jonas-Isr

addressed: preserved the old client and api, moved the new one to a separate dedicated package

@vladimir-a-sap vladimir-a-sap changed the title feat: |RPT] Support version 1.5 alongside the 1.0 feat: |RPT] Update RPT client to version 1.5 Aug 24, 2026
@vladimir-a-sap vladimir-a-sap mentioned this pull request Aug 24, 2026
Open
CharlesDuboisSAP
CharlesDuboisSAP commented Aug 24, 2026
View reviewed changes
Comment thread docs/release_notes.md
### 📈 Improvements

-
- [Foundation Models] Updated SAP-RPT tabular data prediction model client for API `SAP-RPT 1.5`

@CharlesDuboisSAP CharlesDuboisSAP Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The migration guide is lacking, get inspired from https://sap.github.io/ai-sdk/docs/java/release-notes#-compatibility-notes-1

Comment thread sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/services/RptService.java
@@ -82,19 +83,16 @@ public PredictResponsePayload predict() {
*/
@Nonnull
public PredictResponsePayload predictParquet() {

@CharlesDuboisSAP CharlesDuboisSAP Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fails HTTP/1.1 422 Unprocessable Entity.
This what what I talked about with the generator change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@CharlesDuboisSAP CharlesDuboisSAP

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CharlesDuboisSAP @ZhongpinWang @vladimir-a-sap