chore: don't require approval on scheduled canary releases - #2148
chore: don't require approval on scheduled canary releases#2148davidkna-sap wants to merge 2 commits into
Conversation
SummaryThe following content is AI-generated and provides a summary of the pull request: ContextWhat this PR does and why it is neededThis PR updates the Key changes:
This ensures that nightly scheduled canary builds are fully automated without blocking on a manual approval step, while official releases still require explicit sign-off. Category: 🔧 Chore
PR Bot InformationVersion:
|
be8b8b3 to
1c0e046
Compare
| name: Approve Release | ||
| runs-on: ubuntu-latest | ||
| # Scheduled releases may continue without approval, but releases triggered by a GitHub Release require approval. | ||
| environment: ${{ case(github.event_name == 'schedule', 'ensure-main', 'approve-release') }} |
There was a problem hiding this comment.
I am making this conditional here, because otherwise delegate_to_canary_job will need a more complicated if expression.
marikaner
left a comment
There was a problem hiding this comment.
Is there a benefit to adding these additional environments and enforcing them here?
Why don't we just split the release environment into two?
release:
- needs approval, runs on main, registered on npm
canary-release:
- registered on npm
Also:
- The current
ensure-mainenvironment only ensures that this runs on a protected branch, not necessarilymain. - I think it would be nice to allow publishing canary versions from a different branch than main, this is helpful if you need to try something out before merging it.
|
@marikaner We can only register one environment on npm afaik. The way this should work now:
|
Context
Closes SAP/ai-sdk-js-backlog#ISSUENUMBER.
This ensure scheduled event do not require approval.
What this PR does and why it is needed