fix(profile): contain sparse details and show empty state - #31
Merged
Merged
Conversation
voidash
force-pushed
the
fix/member-profile-sparse-details
branch
from
September 27, 2026 12:16
8d1bbab to
35d2719
Compare
Signed-off-by: voidash <ashish.thapa477@gmail.com>
voidash
force-pushed
the
fix/member-profile-sparse-details
branch
from
September 27, 2026 13:19
35d2719 to
b0ed9cc
Compare
abhiyandhakal
approved these changes
Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Keeps a member profile's details laid out correctly when few are filled in, and shows an empty state when none are. This is the change from #20, replayed unchanged onto the rewritten
main.Stacked on #30, which makes Vitest run
*.test.tsx. Without it, this PR's test would silently never run. Merge #30 first; this PR then retargets tomain.Closes #29
Replaces #20. Do not merge #20: it is based on the old history and would bring back 34 old commits and every file that was stripped.
How to check it
bun run test: 143 passed (139 on the base, plus the 4 inmember-profile-content.test.tsx)Checklist