Skip to content

Add a browser smoke test that fails on console errors and SSR fallbacks for every route #861

Closed

Description

@IbrahimIjai

None of the runtime failures below were caught by CI, because unit tests mock the environment and the Playwright suite isn't run (see the e2e-in-CI issue):

Proposal

One Playwright spec (e2e/route-health.spec.ts) that, for each route in src/routes and at desktop and mobile viewports:

  • starts from a clean env (only the committed .env.testnet defaults)
  • asserts the HTTP status is 200 (404 for an unknown route)
  • fails on any pageerror, any console error (allow-list external-network failures via page.route stubs, following the existing helpers in e2e/helpers/), and any "Switched to client rendering" / "Hydration failed" message
  • fails on same-origin 4xx/5xx responses
  • runs axe and fails on critical violations

Acceptance criteria

  • Spec added, and it fails against current main
  • Runs in CI (with the e2e-in-CI issue)

Found while running the web app locally (bun dev, headless Chromium and axe-core sweep of every route at desktop and iPhone-13 sizes) on 2026-10-15, main @ 4c5cf1d. Contributors: follow AGENTS.md / CONTRIBUTING.md. The full commit gate must pass, with no eslint-disable, .skip, or lowered thresholds.

Activity

  1. guptakumarranjeet150 commented on Oct 15, 2026

    @guptakumarranjeet150

    Hi team,

    I analyzed "Add a browser smoke test that fails on console errors and SSR fallbacks for every route" in SO4-Markets/interface and have a concrete technical roadmap to resolve it.

    Technical Implementation Outline:

    1. Audit AST rules and existing unformatted/unwrapped console or logger invocations.
    2. Configure dedicated linting rule enforcement (no-console or strict logger rule) across the workspace.
    3. Refactor affected modules to route log statements through the designated logger utility.
    4. Verify npm run lint / linter check and unit tests pass with zero warnings.

    Please assign this issue to me. I will submit a clean, well-tested, and production-ready PR promptly!

  2. Ay-obami commented on Oct 18, 2026

    @Ay-obami
    Contributor

    @Ay-obami has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    I'll like to work on this issue

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Ay-obami to this issue.

  3. Ghoost-404 commented on Oct 18, 2026

    @Ghoost-404

    @Ghoost-404 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    hello, i'd like to work on this issue please

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Ghoost-404 to this issue.

  4. Jaydbrown commented on Oct 18, 2026

    @Jaydbrown
    Contributor

    @Jaydbrown has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    hello maintainer assign these isssues to me

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Jaydbrown to this issue.

  5. drips-wave commented on Oct 18, 2026

    @drips-wave

    Congratulations, @Jaydbrown! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.

    🧑‍💻 @Jaydbrown: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

    Warning

    When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

    🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

    🌊 Happy Wave 🌊

  6. Jaydbrown commented on Oct 18, 2026

    @Jaydbrown
    Contributor

    Resolved in #996:

    • Added Playwright browser smoke test e2e/route-health.spec.ts testing all routes (/, /trade, /pools, /earn, /referrals, /faucet, /gallery, /changelog, /design-system) at both desktop (1440x900) and mobile (390x844) viewports.
    • Asserts HTTP 200 on all valid routes and verifies 404 behavior on unknown routes.
    • Stubs external network dependencies (binance, stellar.org, gmxinfra.io, pyth.network).
    • Fails on unhandled pageerrors, console errors, SSR hydration mismatches, and same-origin 4xx/5xx responses.
    • Runs automated axe accessibility scans on all routes and fails on critical violations.
  7. drips-wave commented on Oct 19, 2026

    @drips-wave

    This issue has been completed by @Jaydbrown as part of the Stellar Wave Program's 10th Wave 🥳

    😎 @Jaydbrown: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

    🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions