Skip to content

fix(trade): label GMX fallback candles as "GMX Oracle Reference" #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mohit0628 wants to merge 3 commits into
base: main
Choose a base branch
from
+11 −3
Open

fix(trade): label GMX fallback candles as "GMX Oracle Reference" #978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a50074
fix(trade): label GMX fallback candles as "GMX Oracle Reference"
Mohit0628 Oct 15, 2026
28efd34
chore(trade): name changelog entry after PR 978
Mohit0628 Oct 15, 2026
f4e9b28
Merge remote-tracking branch 'SO4-Markets/main' into fix/830-gmx-orac…
Mohit0628 Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changelog/unreleased/978-gmx-oracle-label.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
type: fixed
area: trade
pr: 978
breaking: false
---

The candle chart now labels third-party GMX (Arbitrum) reference prices as "GMX Oracle Reference" instead of the misleading "SO4 Oracle Reference".
6 changes: 3 additions & 3 deletions apps/web/src/features/trade/lib/oracle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ export async function fetchOracleCandles(
const res = await fetch(`${GMX_BASE}/prices/candles?${params}`, { signal })
if (!res.ok) throw new Error(`HTTP ${res.status}`)
const json = (await res.json()) as { candles: Array<Array<number>> }
if (signal?.aborted) return emptyResponse("SO4 Oracle Reference")
if (signal?.aborted) return emptyResponse("GMX Oracle Reference")

const rawBars: Array<OhlcBar> = json.candles
.map(([time, open, high, low, close]) => ({ time, open, high, low, close }))
Expand All @@ -360,13 +360,13 @@ export async function fetchOracleCandles(
return {
candles: validateAndSortCandles(rawBars),
sourceType: "oracle_reference",
venueName: "SO4 Oracle Reference",
venueName: "GMX Oracle Reference",
symbol: base,
period,
network: ENV.NETWORK,
}
} catch {
if (signal?.aborted) return emptyResponse("SO4 Oracle Reference")
if (signal?.aborted) return emptyResponse("GMX Oracle Reference")
throw new Error(`Chart data unavailable for ${symbol}: all candle sources failed`)
}
}
Expand Down