Repository navigation
Conversation
- SO4-Markets#824: Fix import order in TVChartContainer, DepthLadder, ConfirmationDialog. External/builtin imports precede internal/relative imports; type imports follow value imports. Remove unnecessary nullish coalescing in DepthLadder (line 222) and ConfirmationDialog (lines 135-136). Remove unnecessary type assertion in useSourceFreshness.test.ts (line 152). - SO4-Markets#823: Add `test` and `test:coverage` scripts to apps/web/package.json so that turbo test and CI properly run the web test suite. Closes SO4-Markets#824 Closes SO4-Markets#823
|
@QueenGiba Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@QueenGiba is attempting to deploy a commit to the Ijai's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
Consolidated into #988 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#824 — Fix 9 lint errors blocking CI:
#823 — Add
testandtest:coveragescripts to apps/web/package.json so turbo and CI properly run the web test suite.Closes #824
Closes #823