Repository navigation
Conversation
- SO4-Markets#824: Fix import order in TVChartContainer, DepthLadder, ConfirmationDialog. External/builtin imports precede internal/relative imports; type imports follow value imports. Remove unnecessary nullish coalescing in DepthLadder (line 222) and ConfirmationDialog (lines 135-136). Remove unnecessary type assertion in useSourceFreshness.test.ts (line 152). - SO4-Markets#823: Add `test` and `test:coverage` scripts to apps/web/package.json so that turbo test and CI properly run the web test suite. Closes SO4-Markets#824 Closes SO4-Markets#823
…sion prevention - SO4-Markets#732 (OB-093): Create useTxFeedback hook to manage transaction lifecycle with typed events (signing, submitted, confirmed, ordering, settled, error, unknown_outcome). Each transaction attempt gets a stable toast ID that is updated across lifecycle stages without relying on English message matching. Multiple concurrent transactions maintain separate identities. - SO4-Markets#733 (OB-078): Add duplicate submission prevention to useTxSubmit: - Guard against double-click, Enter+click, component rerender via submitInProgress flag - Track attempt identity to correlate submission with hash/status lookup - Detect unknown submission outcomes and signal for status lookup by hash - Only request new signature after explicit user retry, not automatic - Extend useTxSubmit to export submitWithFeedback() for order book and trading flows, while keeping submit() for backward compatibility. Closes SO4-Markets#732 Closes SO4-Markets#733
|
@QueenGiba is attempting to deploy a commit to the Ijai's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@QueenGiba Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
Author
|
Consolidated into #988 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#732 (OB-093) — Introduce
useTxFeedbackhook for explicit transaction lifecycle management:#733 (OB-078) — Add duplicate submission prevention to
useTxSubmit:submitInProgressflag.Implementation
useTxFeedbackhook inapps/web/src/shared/hooks/useTxFeedback.tsxmanages transaction state and toast updates.useTxSubmitwithsubmitWithFeedback()method for order book flows while keepingsubmit()for backward compatibility.Closes #732
Closes #733