Repository navigation
Fix amount truncation precision, SEP-7 domain typo, remove swap files - #992
Merged
Merged
Conversation
…wap files
- parseAmount truncated via Math.floor(x * 10^d) / 10^d, which drops a
unit on binary-rounding inputs ("0.57" became 0.5699999). Truncate the
decimal string instead; add regression test.
- ConnectButton SSR fallback origin pointed at so4.markets (typo of
so4.market), which would route wallet callbacks to a foreign domain.
- Add *.swp to .gitignore after removing committed nano swap files.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Math.floor(x * 10^d) / 10^d, which drops a unit on binary-rounding inputs ("0.57"→0.5699999). Now truncates the decimal string. Regression test added.ConnectButton.tsxSSR fallback washttps://so4.markets(typo ofso4.market); wallet callbacks could have pointed at a foreign domain..swplock files from the repo root; added*.swpto.gitignore.Commit gate
bun run test,bun run test:coverage,bun run buildbun lint,bun typecheck,bun run check:tokensfail identically onmainbefore this change (import/order + no-unnecessary-condition in trade components,TS2304: Cannot find name 'ENV'inConfirmationDialog.tsx, unusedmidPriceinDepthLadder.tsx, existing token violations). None are in files touched here.