Repository navigation
feat(web): motion polish for skeletons, route progress, rolling numbers, and submit morph - #995
Merged
IbrahimIjai merged 4 commits intoOct 19, 2026
Conversation
|
@fortezzalaboratory Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@fortezzalaboratory is attempting to deploy a commit to the Ijai's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds motion polish for skeletons, route navigation, live position numbers, and the place-order button, all built on the existing motion tokens in
globals.css.Issues Resolved
Closes #874
Closes #875
Closes #876
Closes #879
Changes
#874 - [Motion] Rolling-digit number animation
Adds a
RollingNumberprimitive that slides each digit on a transform-only odometer strip, and arollingprop onNumeric. Applied to mark price and PnL in the positions table. Layout is unchanged because digits are fixed-width1chcolumns.#875 - [Motion] Shimmer skeletons and content crossfade
Replaces
animate-pulseinSkeletonwith a transform-only sweep on::before, using a newskeleton-sweepkeyframe. The sweep is disabled under reduced motion, both the OS setting and the in-appdata-reduced-motionflag. Assumption: the crossfade from skeleton to content is left to each call site, since the skeleton component cannot know when its content loads.#876 - [Motion] Route pending indicator
Adds a thin
RouteProgressBarat the top of the viewport driven byuseRouterState().isLoading. It animates transform and opacity only, and isaria-hiddenand pointer-events-none.#879 - [Motion] Submit button state morph
In the confirmation dialog, the confirm button crossfades between its label and a spinner inside one grid cell, so the width does not jump. Assumption: the spinner-to-check step is not included, because the dialog closes on success and there is no visible check state to morph into.
Not verified
bun lint,bun typecheck,bun run check:tokens,bun run test,bun run build) was not run. Please check it in CI.mainare used (--duration-base,--duration-slow,--ease-in-out,--ease-out).